-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to perform JUnit testing against Azure DW #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure-DW-Junit # Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/bvt/BvtTest.java
Codecov Report
@@ Coverage Diff @@
## dev #903 +/- ##
============================================
- Coverage 48.68% 48.54% -0.14%
+ Complexity 2817 2808 -9
============================================
Files 118 118
Lines 27882 27882
Branches 4642 4642
============================================
- Hits 13574 13536 -38
- Misses 12119 12159 +40
+ Partials 2189 2187 -2
Continue to review full report at Codecov.
|
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/testframework/DBTable.java
Outdated
Show resolved
Hide resolved
Please pull changes from peterbae#6 |
Code Adjustments
ulvii
reviewed
Dec 17, 2018
Remove unused imports. |
…ure-DW-Junit # Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/TestResource.java # src/test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
ulvii
reviewed
Dec 17, 2018
src/test/java/com/microsoft/sqlserver/testframework/DBTable.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Dec 17, 2018
src/test/java/com/microsoft/sqlserver/jdbc/unit/UTF8SupportTest.java
Outdated
Show resolved
Hide resolved
cheenamalhotra
previously approved these changes
Dec 17, 2018
ulvii
reviewed
Dec 17, 2018
src/test/java/com/microsoft/sqlserver/jdbc/connection/NativeMSSQLDataSourceTest.java
Outdated
Show resolved
Hide resolved
…ure-DW-Junit # Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/bvt/BvtTest.java # src/test/java/com/microsoft/sqlserver/testframework/AbstractTest.java
lilgreenbird
added a commit
to lilgreenbird/mssql-jdbc
that referenced
this pull request
Dec 18, 2018
lilgreenbird
approved these changes
Dec 18, 2018
cheenamalhotra
approved these changes
Dec 18, 2018
ulvii
approved these changes
Dec 18, 2018
lilgreenbird
added a commit
that referenced
this pull request
Dec 25, 2018
* ported tests from VSO and added tests to increase code coverage * moved resultset tests to resultset * removed unused import * added tests to increase code coverage * fixed issue with timezone * fixed issue with timezone * modified testWithThaiLocale to use current time * fixed issue with timezone * fixed issue with timezone * fixed issue with timezone * added SparseTest and BigIntegerTest and cleaned up with try-with-resources * review changes * review comments * more review updates * review updates * removed dummy file * review udpates * more cleanup * updated isSqlAzure * review updates * more review updates * fixed imports * updated failed error strings with more detail * added locale to time format * format date for comparision * 1 more timezone fix * cleanup leaded stream resources * manually merged with #903 changes for now * more cleanup on assertEqual checks * more cleanup on assertEqual checks * cosmetic changes from review * updated all assertEquals params to proper expected, actual order * fixed comments and leaked resultsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command to perform only Azure DW Test:
mvn clean install -DtestGroup=AzureDWTest
(and you also need to either provide the mssql_jdbc_test_connection_properties environment variable yourself, or modify that variable in the AbstractTest.java file)
This test can be performed along with the build42/build43 profiles.
The regular JUnit test has about ~450 test cases, so the Azure DW test suite currently tests about 25% of the regular JUnit test plan, and this number will be brought up in the near future.
Added test results screenshots to the PR.