-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate subscriptions engine to graphql-yoga #1578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MichalLytek Awesome. What is missing? |
@carlocorradini Fixing pipeline issues, upgrading redis subscriptions example. |
Can I help somehow? |
@MichalLytek See PR #1590 🤗🥳 |
70b134e
to
003088e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
- Coverage 95.52% 95.50% -0.02%
==========================================
Files 113 113
Lines 1854 1848 -6
Branches 367 364 -3
==========================================
- Hits 1771 1765 -6
Misses 83 83 ☔ View full report in Codecov by Sentry. |
MichalLytek
commented
Jan 3, 2024
MichalLytek
commented
Jan 3, 2024
…ide and the changelog
96fbd30
to
e339b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@graphql-yoga
instead ofgraphql-subscriptions
as the subscriptions enginePubSub
implementation intobuildSchema
option when using@Subscription
@PubSub
in favor of directly importing createdPubSub
implementationPublisher
andPubSubEngine
types@Subscription
decorator option