Skip to content

Commit

Permalink
Workaround for double clicking item bug. This is a workaround for bug n…
Browse files Browse the repository at this point in the history
…extcloud#893, where if you double click an item that opens in the viewer, it opens in a way that the viewer can't close.  It works for the Viewer for Images, Videos, and PDFs for sure.  I didn't test audio, but it probably works for it as well.  The main cause of the issue is that when a file is double clicked, the file is opened twice.  However, something weird occurs when this happens.  openFile() is only called once, while close() and cleanup() are immediately called.  What I'm guessing happens is that the original file loads, and is closed somehow, followed by the second file opening.  I'm not sure which of those files calls openFile() and which doesn't.  One result of this though is that when the second file is closed, close() is called, but cleanup() is not.  This patch ensures that it is called, which resolves the issue.  There are still some cases where the double clicking can cause the black background of the viewer to not appear (to get this to happen, you have to double click, but put some spaces between the clicks that are a part of the double click, it's difficult to get the timing right, so try it a few times).  But this at least solves the one issue.  This is not really meant to be a permanent workaround probably.  There are better things to do then run cleanup(), but I can't set up my development environment well enough to test it.  But this is suitable for now.

Signed-off-by: Michael Pope <michael.pope.email@gmail.com>
  • Loading branch information
Michael Pope committed Apr 21, 2022
1 parent 7451ab4 commit 53d44aa
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/views/Viewer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,11 @@ export default {
if (OCA?.Files?.Sidebar) {
OCA.Files.Sidebar.setFullScreenMode(false)
}

//deals with a bug that occurs when double clicking on an item in NextCloud
//may be good to replace this with something more suitable in the future (not sure if cleanup() really belongs here)
this.cleanup();

},

cleanup() {
Expand Down

0 comments on commit 53d44aa

Please sign in to comment.