Skip to content

Commit

Permalink
refactor: use esbuild-plugins-node-modules-polyfill
Browse files Browse the repository at this point in the history
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill`

The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead
https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16

But the Remix repo (see remix-run/remix#5274) tried this and found some regressions.
So they chose to go for @imranbarbhuiya's  `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative.

Users should no longer see the following deprecation warnings when installing Wrangler:

```sh
npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
```

Resolves cloudflare#1232
  • Loading branch information
MichaelDeBoey authored and petebacondarwin committed Mar 16, 2024
1 parent 38e08fc commit 9da3533
Showing 1 changed file with 118 additions and 19 deletions.
137 changes: 118 additions & 19 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9da3533

Please sign in to comment.