Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade reqwest and pulldown-cmark dependencies #26

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Feb 26, 2020

About the changes:

  • use_sys_proxy is now default
  • somehow serde stops working with new reqwest unless derive feature is enabled
  • codespan is left with old version because I didn't know how to solve breaking changes

@Michael-F-Bryan
Copy link
Owner

@mati865 it looks like the travis build failed, any idea what might have caused it?

@mati865
Copy link
Contributor Author

mati865 commented Feb 27, 2020

I think Travis has changed their images to not include openssl by default any more.
To confirm that I triggered build for current master branch and it failed the same way: https://travis-ci.com/mati865/mdbook-linkcheck/builds/150833470

You can install openssl-dev package on the CI to solve it.

@palfrey
Copy link
Contributor

palfrey commented Mar 1, 2020

#29 fixes the build issues

@Michael-F-Bryan
Copy link
Owner

@mati865, would you be able to do a git rebase and see if CI is happy again?

@mati865
Copy link
Contributor Author

mati865 commented Mar 2, 2020

It's green now.

@Michael-F-Bryan Michael-F-Bryan merged commit da73d5e into Michael-F-Bryan:master Mar 3, 2020
@mati865 mati865 deleted the deps branch March 4, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants