Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix observer decorators #27

Merged
merged 3 commits into from
Feb 26, 2022
Merged

Hotfix observer decorators #27

merged 3 commits into from
Feb 26, 2022

Conversation

MetinSeylan
Copy link
Owner

@MetinSeylan MetinSeylan commented Feb 26, 2022

#26

Copy link
Contributor

@ilter ilter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@@ -41,6 +41,8 @@ export class DecoratorCounterMetricInjector extends BaseMetricInjector {
!this.isAffected(provider.metatype.prototype[key])
) {
const options = this.getOptions(provider.metatype.prototype[key]);
if (options.type !== DecoratorType.COUNTER) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does inline return decrease readability, doesn't it?

@MetinSeylan MetinSeylan merged commit 573b10f into main Feb 26, 2022
@MetinSeylan MetinSeylan linked an issue Feb 26, 2022 that may be closed by this pull request
@MetinSeylan MetinSeylan deleted the hotfix/decorator branch March 2, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Counter is registered as @Observer
2 participants