New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate code #38

Merged

huppd merged 23 commits into main from rm_duplicate_code

Aug 26, 2024

Collaborator

huppd commented Aug 6, 2024

The PR refactors code duplication and activates pylint to check it.

huppd added 13 commits

August 6, 2024 14:01


          add test

a89098a


          rm more dublicate

ce0b8ad


          rm more

70c64a0


          cleanup code

ea8a7fe


          refactor more

3da24a5


          change to error

09539e4


          add doc string

a059de3


          add test

816e46d


          cleanup

069d255


          cleanup

4aa72cb


          refactor dublicate

7f5e58f


          add test

9909d5a


          cleanup test

54baec7

jonasjucker reviewed

View reviewed changes

tests/engine/test_perturb.py Show resolved Hide resolved

jonasjucker reviewed

View reviewed changes

tests/helpers.py Outdated Show resolved Hide resolved

jonasjucker reviewed

View reviewed changes

tests/test_helpers.py Outdated Show resolved Hide resolved

jonasjucker reviewed

View reviewed changes

tests/util/icon/test_timing_tree.py Outdated Show resolved Hide resolved

jonasjucker reviewed

View reviewed changes

tests/util/icon/test_timing_tree.py Outdated Show resolved Hide resolved

jonasjucker reviewed

View reviewed changes

tests/util/test_dataframe_ops.py Outdated Show resolved Hide resolved

jonasjucker reviewed

View reviewed changes

tests/util/test_dataframe_ops.py Outdated Show resolved Hide resolved

jonasjucker requested changes

View reviewed changes

Collaborator

jonasjucker left a comment

I think it would be good to not come up with a parallel infrastructure with regard to testing.
Therefore I think it makes sense to convert the tests you worked on into pytest-test.

Otherwise only minor comments.

huppd added 6 commits

August 9, 2024 12:17


          rm print

bdb765a


          mv fixture

b056a76


          change to pyttest

d344e21


          cleanup fixtures

92e5ec3


          change to pytest

1e7b345


          rm logger test

8b0688c

jonasjucker reviewed

View reviewed changes

tests/util/icon/test_timing_tree.py Outdated Show resolved Hide resolved

jonasjucker reviewed

View reviewed changes

tests/engine/test_perturb.py Outdated Show resolved Hide resolved

jonasjucker requested changes

View reviewed changes

Collaborator

jonasjucker left a comment

Some more questions...

huppd added 4 commits

August 26, 2024 09:14


          cleanup timing tree test


          cleanup fixtures

94f1a38


          add tmp_dir

85f1a13


          fix test

9ff7e0c

jonasjucker self-requested a review

August 26, 2024 11:41

jonasjucker approved these changes

View reviewed changes

Collaborator

jonasjucker left a comment

LGTM

huppd merged commit 3b7d668 into main

3 checks passed

jonasjucker deleted the rm_duplicate_code branch

August 26, 2024 11:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet