Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pragma once warning in AST/Offsets #985

Merged
merged 1 commit into from
May 28, 2020
Merged

Fix pragma once warning in AST/Offsets #985

merged 1 commit into from
May 28, 2020

Conversation

jdahm
Copy link
Contributor

@jdahm jdahm commented May 28, 2020

Technical Description

Using #pragma once uncovered an issue in AST/Offsets.cpp. This PR fixes that and cleans up the file.

@jdahm
Copy link
Contributor Author

jdahm commented May 28, 2020

launch jenkins

@jdahm jdahm requested a review from eddie-c-davis May 28, 2020 22:59
eddie-c-davis
eddie-c-davis reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@eddie-c-davis eddie-c-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with one question.

eddie-c-davis
eddie-c-davis approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@eddie-c-davis eddie-c-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jdahm jdahm merged commit bc24e15 into MeteoSwiss-APN:master May 28, 2020
@jdahm jdahm deleted the fix_offsets branch May 28, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddie-c-davis eddie-c-davis eddie-c-davis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdahm @eddie-c-davis