Remove DawnCompiler #886
Merged
Remove DawnCompiler #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3695bc8.
2 tasks
|
launch jenkins |
|
launch jenkins |
jdahm
commented
Apr 17, 2020
| @@ -295,11 +279,6 @@ void GTClangASTConsumer::HandleTranslationUnit(clang::ASTContext& ASTContext) { | |||
| } else { | |||
| num_stencils_generated++; | |||
| } | |||
| if(context_->getOptions().DeserializeIIR && num_stencils_generated > 1) { | |||
There was a problem hiding this comment.
This was removed because deserializeIIR is no longer a supported option
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
|
launch jenkins |
jdahm
added a commit
that referenced
this pull request
Apr 21, 2020
Removes the CompilerUtil testing class. Builds on #886.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Description
Remove the DawnCompiler class. This requires many tests to change their usage of the optimizer and code generation.
To dos:
Notable changes
-write-iirnow writes to a file called${stencilname}.iirinstead of${filename}.%d.iir. This was unfortunately necessary because where it is serialized we do not have access to the filenamedawn/scripts/refactorwas moved up a directorydawn/scripts/make_pybind11_sources.pynow automatically overwrites thedawn4py/_dawn4py.cppfiledawn4pybindings changedResolves / Enhances
Resolves #874, #900.
Depends on #877.
Testing
http://localhost:8080/job/dawn_gtclang_clang-gridtools_PR/525/