Try-catch correctly with dawn-opt #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twicki
suggested changes
Mar 18, 2020
jdahm
commented
Mar 18, 2020
| @@ -195,10 +195,6 @@ DawnCompiler::lowerToIIR(const std::shared_ptr<SIR>& stencilIR) { | |||
| throw std::runtime_error("An error occurred."); | |||
|
|
|||
| DAWN_LOG(INFO) << "Done with parallelization passes for `" << instantiation->getName() << "`"; | |||
|
|
|||
| if(options_.DumpStencilInstantiation) { | |||
There was a problem hiding this comment.
This was being printed twice to screen. Oops!
|
launch jenkins |
twicki
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Description
Correctly try-catch with dawn-opt. Involves removing incorrect
dawn_unreachable(...)calls and replacing these with throws. The serialization functions should no longer usedawn_unreachable(...)in the future.