Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: move from built-in node streams to readable-stream #96

Merged
merged 4 commits into from
Nov 22, 2023
Merged

deps: move from built-in node streams to readable-stream #96

merged 4 commits into from
Nov 22, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 25, 2023 •
edited
Loading

Currently, the module uses native stream (API version depending on runtime) together with through2.

This moves to portable readable-stream@^3.6.2 and removes the through2 dependency. Also removes devDependency mississippi, replacing with readable-stream.

Blocking

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 25, 2023
@socket-security
Copy link

socket-security bot commented Sep 25, 2023 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @types/through2@2.0.36, mississippi@1.2.0, through2@2.0.3

@kumavis
Copy link
Member

kumavis commented Nov 16, 2023

should maybe prefer readable-streams

@legobeat legobeat changed the title deps: replace through2 with native stream api deps: move from built-in node streams to readable-stream Nov 22, 2023
@legobeat
Copy link
Contributor Author

Changed implementation from stream to readable-stream.

@legobeat legobeat marked this pull request as ready for review November 22, 2023 10:55
@legobeat legobeat requested a review from a team as a code owner November 22, 2023 10:55
@legobeat legobeat requested review from FrederikBolding, a team and kumavis November 22, 2023 10:55
FrederikBolding
FrederikBolding reviewed Nov 22, 2023
View reviewed changes
@legobeat legobeat mentioned this pull request Nov 22, 2023
Merged
1 task
@legobeat legobeat requested review from a team November 22, 2023 11:28
@legobeat legobeat mentioned this pull request Nov 22, 2023
Merged
18 tasks
@legobeat legobeat merged commit 27e4e19 into MetaMask:main Nov 22, 2023
@legobeat legobeat mentioned this pull request Jan 15, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @kumavis @FrederikBolding