Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 13708 fix the submitQRSignature scope issue. #13714

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dawnseeker8
Copy link
Contributor

Description

This QR is to fix the bug report #13708 ,
The affect area was Personal sign, Sign Typed data v4, sign permit feature.
The error was caused by submitQRSignature didnt provide the bind() function to KeyringController, which make the this scope in KeyringController change. which cause this.getOrAddQRKeyring is not a function error.

Related issues

Fixes: #13708

Manual testing steps

1.Install MM
2. Recover from SRP
3. Add hardware wallet (QR - Keystone)
4. Import QR accounts from device
5. Visit Test dapp
6. Connect QR account
7. Sign permit / Sign typed data v4

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dawnseeker8 dawnseeker8 added team-hardware-wallets Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Feb 25, 2025
@dawnseeker8 dawnseeker8 requested a review from a team as a code owner February 25, 2025 12:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 275b409
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/98f86553-cdb9-4194-a475-e5da2c305ffe

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 81ae8f9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e32bddd-e9bc-4940-abf0-ff3f4afac109

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vivek-consensys vivek-consensys added the QA Passed A successful QA run through has been done label Feb 25, 2025
@vivek-consensys
Copy link
Contributor

Tested on iOS using Bitrise Build .

@dawnseeker8 dawnseeker8 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 9bc05fc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1e4ec4cf-674a-4e3a-bec2-35f30e41dfc1

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed A successful QA run through has been done Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team team-hardware-wallets
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to sign transactions on QR hardware wallet
2 participants