Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: @metamask/transaction-controller version to exact 45.0.0 #13690

Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix: @metamask/transaction-controller version to exact 45.0.0 #13690

merged 2 commits into from
Feb 24, 2025
+12 −11

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Feb 24, 2025 •
edited by sethkfman
Loading

Description

Related issues

Fixes: #13570

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested review from a team as code owners February 24, 2025 15:14
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 24, 2025
@socket-security Socket Security
Copy link

socket-security bot commented Feb 24, 2025 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/transaction-controller@45.0.0 🔁 npm/@metamask/transaction-controller@45.1.0 None 0 2.18 MB metamaskbot

View full report↗︎

jpuri
jpuri previously approved these changes Feb 24, 2025
View reviewed changes
@OGPoyraz OGPoyraz added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 383e543
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8888da88-f560-4ae8-9ced-6e9c0adb76d6

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

digiwand
digiwand reviewed Feb 24, 2025
View reviewed changes
@digiwand
Copy link
Contributor

there is a lint error blocking merge
CleanShot 2025-02-24 at 10 33 28@2x

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: f232cc2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e395be2f-e38e-4fcf-b867-26a23713798d

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sethkfman
sethkfman approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 894a347 Feb 24, 2025
46 of 47 checks passed
@jpuri jpuri deleted the fix/transaction-controller-version branch February 24, 2025 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 24, 2025
@digiwand digiwand added release-7.41.0 Issue or pull request that will be included in release 7.41.0 and removed release-7.42.0 Issue or pull request that will be included in release 7.42.0 labels Feb 24, 2025
@digiwand
Copy link
Contributor

cherry-picked to 7.41 #13695

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand left review comments

@jpuri jpuri jpuri approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Invalid QR Code when attempting to send/swap using Keystone device
5 participants
@OGPoyraz @digiwand @jpuri @sethkfman @metamaskbot