Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Assign platform team as codeowners to Engine files #13670

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 21, 2025

Description

These changes adds platform team as the codeowners to the remaining files within the Engine directory.

Related issues

Fixes: Slack thread - https://consensys.slack.com/archives/C087GPTR5HQ/p1740093225670229

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Feb 21, 2025
@Cal-L Cal-L requested a review from a team as a code owner February 21, 2025 17:51
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L enabled auto-merge February 21, 2025 17:53
@Cal-L Cal-L changed the title chore: Add controller init to platform codeowners chore: Assign platform team as codeowners to Engine files Feb 21, 2025
@Cal-L Cal-L added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit dc0fc6b Feb 21, 2025
53 of 54 checks passed
@Cal-L Cal-L deleted the chore/add-controller-init-to-platform-codeowners branch February 21, 2025 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-mobile-platform Mobile Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants