-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor cleanup notification hooks and UI #13647
feat: refactor cleanup notification hooks and UI #13647
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…tor-cleanup-notification-hooks-and-ui
|
|
app/components/Views/Settings/NotificationsSettings/FeatureAnnouncementToggle.test.tsx
Show resolved
Hide resolved
app/components/Views/Settings/NotificationsSettings/FeatureAnnouncementToggle.tsx
Show resolved
Hide resolved
app/components/Views/Settings/NotificationsSettings/FeatureAnnouncementToggle.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
A PR we split from the main feature branch here.
I was planning to keep the scope small, but updating hooks, also required updating UI components and views.
Important: this feature is feature switched and will not touch and impact the mobile app.
PR Walkthrough
https://www.loom.com/share/fd7d9b5b8a0a44f99533569aada0d6ec?sid=4be353d7-9ea4-40f0-a1f4-dc83e6a40165
Related issues
Fixes:
Manual testing steps
N/A - notifications feature is not enabled yet. Once all the files in the Feature Branch are merged, we should be able to then start some thorough testing.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist