Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor cleanup notification hooks and UI #13647

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Feb 20, 2025

Description

A PR we split from the main feature branch here.
I was planning to keep the scope small, but updating hooks, also required updating UI components and views.

Important: this feature is feature switched and will not touch and impact the mobile app.

PR Walkthrough

https://www.loom.com/share/fd7d9b5b8a0a44f99533569aada0d6ec?sid=4be353d7-9ea4-40f0-a1f4-dc83e6a40165

Related issues

Fixes:

Manual testing steps

N/A - notifications feature is not enabled yet. Once all the files in the Feature Branch are merged, we should be able to then start some thorough testing.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya changed the title Refactor cleanup notification hooks and UI feat: refactor cleanup notification hooks and UI Feb 20, 2025
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7e92f0c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/abedbe32-c802-4d8e-8669-046fbbb68d17

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 20, 2025
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review February 20, 2025 19:13
@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners February 20, 2025 19:13
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 1243314 Feb 21, 2025
47 of 48 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the refactor-cleanup-notification-hooks-and-ui branch February 21, 2025 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants