Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cp-7.41.0 implement transparent app icons for improved dark/light mode handling #13597

Merged
merged 12 commits into from
Feb 24, 2025
Merged

fix: cp-7.41.0 implement transparent app icons for improved dark/light mode handling #13597

merged 12 commits into from
Feb 24, 2025
+203 −338

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Feb 18, 2025 •
edited
Loading

Description

Issue: Our app icons were stuck in dark mode and ignored light mode settings in TestFlight builds (while working correctly locally). The build process was stripping the light mode icons during compilation.

Solution: Implement transparent background app icons that leverage iOS system defaults:

  • Light mode: System automatically applies white background
  • Dark mode: System automatically applies gradient black background
    This matches our brand color schemes perfectly and simplifies our icon management.

Additional Changes:

  • Removed legacy CFBundleIcons dictionary from Info.plist
  • Kept only the modern CFBundleIconName entry
  • Simplified asset catalog configuration to use transparent icons

Risk Assessment:

  • Primary risk is potential App Store rejection due to transparent app icons
  • However, many apps successfully use this approach
  • Fallback backgrounds are consistent with our brand guidelines
  • Simplifies our icon management and build process

Testing:

  • Verified icons display correctly in development
  • Confirmed proper light/dark mode behavior locally

Next Steps:

  • Monitor App Store review process
  • Have backup solution with explicit backgrounds if needed
  • Document this approach for future reference

Related issues

Fixes: #4226

Manual testing steps

  1. Install a fresh app
  2. Hold down on the home screen until the apps jiggle, indicating that the icons can be moved/deleted/edited
  3. Click on the "Edit" button at the top right or left depending on the device, and click "Customize"
  4. A bottom sheet should appear allowing you to toggle light, dark, and tint
  5. Confirm that those still work

Screenshots/Recordings

Release Build

ScreenRecording_02-20-2025.12-04-18_1.MP4

Before

Screenshot 2025-02-17 at 09 51 36

After

after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added No E2E Smoke Needed If the PR does not need E2E smoke test run team-wallet-ux labels Feb 18, 2025
@vinnyhoward vinnyhoward requested a review from a team as a code owner February 18, 2025 22:10
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot requested a review from a team as a code owner February 18, 2025 23:13
@vinnyhoward vinnyhoward force-pushed the fix-4226-dark-mode-bug branch from 19be86a to 5262c29 Compare February 19, 2025 20:16
@vinnyhoward vinnyhoward force-pushed the fix-4226-dark-mode-bug branch from 4f66a8f to 2d2e796 Compare February 20, 2025 00:10
@vinnyhoward vinnyhoward force-pushed the fix-4226-dark-mode-bug branch from 965aedd to 2d43483 Compare February 20, 2025 18:37
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2d43483
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3451cfe8-ccb5-48b6-b4ae-7a503c04d014

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward changed the title fix(4226): remove legacy icon configuration from info.plist fix(4226): update app icons to be transparent Feb 20, 2025
@vinnyhoward vinnyhoward changed the title fix(4226): update app icons to be transparent fix(4226): implement transparent app icons for improved dark/light mode handling Feb 20, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5411506
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65a7100a-78da-4a8c-970a-aeffeb5b70e0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 556d7fd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00bed2cd-0c04-4b20-a480-e69db0a06349

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 21, 2025
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c99de32
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa593e7f-23c6-4ae9-af33-f2f63ba01e92

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman changed the title fix(4226): implement transparent app icons for improved dark/light mode handling fix: cp-7.41.0 implement transparent app icons for improved dark/light mode handling Feb 24, 2025
sethkfman
sethkfman approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 318354d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/099b9a31-509a-45fd-8b38-bf2765451d34

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 24, 2025
@MarioAslau MarioAslau added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 3d1e941 Feb 24, 2025
46 of 47 checks passed
@MarioAslau MarioAslau deleted the fix-4226-dark-mode-bug branch February 24, 2025 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinnyhoward @sethkfman @MarioAslau @metamaskbot