You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this task is to reduce the instances of events being logged to Segment to only 1% of the current volume. The solution is to randomly select 1% of USERS (NOT EVENTS) to be tracked, and ignore the other 99%.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
smilingkylan
changed the title
Limit Segment tracked events to only random 1% of users
feat: Limit Segment tracked events to only random 1% of users
Feb 14, 2025
## Explanation
The purpose of this PR is to export the `remote-feature-flag-controller`
method `generateDeterministicRandomNumber` for use within the UI. I am
not inserting it as a controller method because we should not need to
instantiate the controller in order to use it.
## References
Issue: MetaMask/MetaMask-planning#4119
Related PR: MetaMask/metamask-mobile#13534
## Changelog
### `@metamask/remote-feature-flag-controller`
- **CHANGED**: Export `generateDeterministicRandomNumber` from
`remote-feature-flag-controller`
## Checklist
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this task is to reduce the instances of events being logged to Segment to only 1% of the current volume. The solution is to randomly select 1% of USERS (NOT EVENTS) to be tracked, and ignore the other 99%.
Related issues
Fixes: #4119
Core PR: MetaMask/core#5341
Manual testing steps
To manually test you can opt-in to being tracked via the account creation user flow, then check MixPanel to see if the events were logged or not.
Screenshots/Recordings
Before
n/a 100% of Segment events are currently being tracked
After
To test, I changed the % to 50%, went through the onboarding flow 4x and saw that exactly 2 of the 4 (50%) were logged to Segment / MixPanel
Users:
Pre-merge author checklist
Pre-merge reviewer checklist