Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add AlertModal component #13483

Merged
merged 24 commits into from
Feb 25, 2025
Merged

feat: add AlertModal component #13483

merged 24 commits into from
Feb 25, 2025

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Feb 13, 2025

Description

This PR aims to add a new component for the alert system AlertModal.
Until we add an alert there is no functional change in the app.

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2136

Manual testing steps

  1. Only E2E

Screenshots/Recordings

test.mp4

Before

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label Feb 13, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam marked this pull request as ready for review February 14, 2025 14:56
@vinistevam vinistevam requested review from a team as code owners February 14, 2025 14:56
@vinistevam vinistevam added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 17, 2025
Copy link
Contributor

github-actions bot commented Feb 17, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4dbcc43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f6b6dafa-93d6-4053-bd62-90100888bd08

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Base automatically changed from feat/initial-structure-alert-system to main February 20, 2025 14:04
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedback here. Can be addressed in this or a following PR.

@vinistevam vinistevam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 549e386
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8514ff8d-48a0-4c56-836d-c623e8458ae5

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinistevam vinistevam added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit bcbeb06 Feb 25, 2025
42 of 43 checks passed
@vinistevam vinistevam deleted the feat/add-alert-modal branch February 25, 2025 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants