Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ramp): MMQA-217: Add off-ramp e2e test cases for quotes #13482

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

C-Ivan
Copy link
Contributor

@C-Ivan C-Ivan commented Feb 13, 2025

Description

https://consensyssoftware.atlassian.net/browse/MMQA-217

Adding 2 new e2e test cases for ramps.

New scenarios:
Order limits - Min/max limits and insufficient balance
Select a quote

Related issues

Manual testing steps

Screenshots/Recordings

Show quotes (it's not showing the quotes because it's being run locally, but in Bitrise it's displaying them):
https://www.loom.com/share/871404109b4f47cdbd1f3d0c0a5e2b74?sid=4f06644c-2ba6-467c-85de-7fb4e7ca739f

Limits:
https://www.loom.com/share/8d32bd324c384c4ead2eb5de3e12f483?sid=ada1b345-5837-4bd4-ae1f-c59474c0ec3a

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 13, 2025
@C-Ivan C-Ivan added the team-ramp issues related to Ramp features label Feb 13, 2025
@C-Ivan C-Ivan added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7de24e0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/710f2d0c-35d7-4639-91a7-2af56ef803ae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@C-Ivan C-Ivan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 203484c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1754cd89-6484-40b3-905b-91411f7d11a8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@C-Ivan C-Ivan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 86f5c55
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c47d8d1a-1728-47ef-84bf-ef024de817f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@C-Ivan C-Ivan marked this pull request as ready for review February 20, 2025 10:15
@C-Ivan C-Ivan requested review from a team as code owners February 20, 2025 10:15
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@C-Ivan C-Ivan added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 256bc97 Feb 21, 2025
39 checks passed
@C-Ivan C-Ivan deleted the e2e_offramp_quotes branch February 21, 2025 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-qa QA team team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants