-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send max main branch #13279
base: main
Are you sure you want to change the base?
fix: send max main branch #13279
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 3ea54ad Note
|
Bitrise✅✅✅ Commit hash: 1a34d49 Note
|
Quality Gate passedIssues Measures |
Description
This PR fixes an issue where if the gas estimates were not available, the user would literally try to send 100% of their gas token balance, which is impossible since we always need to account for gas. But if gas estimates were unavailable, the estimated gas would be calculated as
0
.Therefore, we just block the
Use Max
button if we have no gas estimates available in the odd case where the user has network connectivity but no gas estimates (possibly a provider is down).Related issues
Fixes: #13215
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist