Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send max main branch #13279

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Jan 30, 2025

Description

This PR fixes an issue where if the gas estimates were not available, the user would literally try to send 100% of their gas token balance, which is impossible since we always need to account for gas. But if gas estimates were unavailable, the estimated gas would be calculated as 0.

Therefore, we just block the Use Max button if we have no gas estimates available in the odd case where the user has network connectivity but no gas estimates (possibly a provider is down).

Related issues

Fixes: #13215

Manual testing steps

  1. Go to Send
  2. Notice that Use Max is disabled and greyed out if no gas estimates

Screenshots/Recordings

Before

After

IMG_0005

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review January 30, 2025 20:08
@infiniteflower infiniteflower requested a review from a team as a code owner January 30, 2025 20:08
@infiniteflower infiniteflower changed the title Fix/send max main branch fix: send max main branch Jan 30, 2025
@infiniteflower infiniteflower added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3ea54ad
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbf23ab9-f22a-458a-9f78-a59f0ff7f64c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@infiniteflower infiniteflower added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1a34d49
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/557e1840-87e4-4166-9a69-96bf0db2bf33

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@infiniteflower infiniteflower added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: not able to send "Use Max" assets, always getting JSON-RPC error
2 participants