Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: "Unlimited" value Decoding Simulation and account and message modal UI/UX updates #13030

Merged
merged 90 commits into from
Jan 16, 2025
Merged

feat: "Unlimited" value Decoding Simulation and account and message modal UI/UX updates #13030

merged 90 commits into from
Jan 16, 2025
+62 −25

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jan 16, 2025 •
edited
Loading

Description

Feat:

  • Support "Unlimited" display values in decoding simulation
  • Update account detail and message modals to have transparent backgrounds and enable click to close on background

Note: It might be helpful to walk through the commits to review

Related issues

Fixes: #13022
Relates to: #12994

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

CleanShot 2025-01-16 at 03 23 30
CleanShot 2025-01-16 at 04 12 30

After

CleanShot 2025-01-16 at 03 22 54
CleanShot 2025-01-16 at 03 20 50

Before without "Unlimited" support

After "Unlimited" support

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

digiwand added 30 commits December 6, 2024 21:53
@digiwand
feat: Permit Simulation
87b746e 
todo:
- metrics
- precision tooltip
- tests
- styles:
  - right align row values
  - hide
@digiwand
refactor: PermitSimulation const name
60086e1
@digiwand
fix: label_change_type i18n
ae2a2cb
@digiwand
feat: add PermitSimulation metrics
5b5d094
@digiwand
feat: create ButtonPill component
dfc086f
@digiwand
feat: PermitSimulation token value BottomModal
d96f9aa
@digiwand
Merge branch 'main' into feat-permit-simulation
a665679
@digiwand
feat: Add Permit Simulation to TypedSignV3V4 redesign
518e51d
@digiwand
refactor: cleanup
f069e37
@digiwand
chore: update todo ValueDisplay shorten comment
fe15f12
@digiwand
refactor: update useGetTokenStandardAndDetails import
6777319
@digiwand
fix: PermitSimulation changeType
4bc90e0
@digiwand
test: PermitSimulation
b65adf3
@digiwand
fix: useTrackERC20WithoutDecimalInformation should run once
a79f2cd
@digiwand
fix: include typedSignV4ConfirmationState for PermitSimulation test
a5d96ec
@digiwand
test: create PermitSimulationValueDisplay test
05669d3 
todo:
- fix rerender issue
- fix removeEventListener detached console error
@digiwand
fix: TS lint signature util
bcccb06
@digiwand
Merge branch 'main' into feat-permit-simulation
22f754f
@digiwand
fix: readd dep to useTrackERC20WithoutDecimalInformation
567fc66
@digiwand
chore: update useTrackERC20WithoutDecimalInformation TS metricLocation
0c215c4
@digiwand
test: ValueDisplay test
1683123
@digiwand
fix: test allow style param InfoAddress
79a4003
@digiwand
test:fix: OrderDetails allow undefined style param
aa43eb9
@digiwand
test:fix: include InfoAddress undefined style param
8577591
@digiwand
chore: ButtonPill pressed -> isPressed
d53035f
@digiwand
build: mv ButtonPill files -> components-temp
2bdb950
@digiwand
test: create confirmations/utils/signature test
1ffe22e
@digiwand
test: add parseTypedDataMessage tests
779f36f
@digiwand
test: add shortenString tests for skipCharacterInEnd + update TS
5852d87
@digiwand
Merge branch 'main' into feat-permit-simulation
fce5367
@digiwand digiwand added the team-confirmations Push issues to confirmations team label Jan 16, 2025
@digiwand digiwand requested review from a team as code owners January 16, 2025 12:11
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b375f13
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/947194d2-0134-43d3-985a-3d3d9007d7c5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@digiwand digiwand changed the title feat: Redesign Signature Simulation updates feat: Redesign Signature Simulation "Unlimited" value support and account and message modal updates Jan 16, 2025
@digiwand digiwand changed the title feat: Redesign Signature Simulation "Unlimited" value support and account and message modal updates feat: "Unlimited" value Decoding Simulation and account and message modal UI/UX updates Jan 16, 2025
@digiwand digiwand mentioned this pull request Jan 16, 2025
Merged
7 tasks
Base automatically changed from feat-decoding-simulation to main January 16, 2025 15:51
@github-actions github-actions bot requested a review from a team as a code owner January 16, 2025 15:51
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
69.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@digiwand digiwand added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit d044c1c Jan 16, 2025
36 of 37 checks passed
@digiwand digiwand deleted the feat-signature-simulation-updates branch January 16, 2025 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees
No one assigned
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "Unlimited" display values in Redesign TypedSign pages
3 participants
@digiwand @matthewwalsh0 @metamaskbot