Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "Spending cap" is shown instead of "Revoke" for revoke type decoding simulation state changes #13664

Closed
digiwand opened this issue Feb 21, 2025 · 0 comments · Fixed by #13665
Closed

[Bug]: "Spending cap" is shown instead of "Revoke" for revoke type decoding simulation state changes #13664

digiwand opened this issue Feb 21, 2025 · 0 comments · Fixed by #13665
Assignees
@digiwand
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@digiwand
Copy link
Contributor

Describe the bug

"Spending cap" is shown instead of "Revoke" for revoke type decoding simulation state changes

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

Create a decoding simulation for revoke

Error messages or log output



Detection stage


In production (default)


Version


7.39.0


Build type


None


Device


n/a


Operating system


iOS


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @digiwand
digiwand




          added
  the 

  type-bug

  Something isn't working
 label


      Feb 21, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Feb 21, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by team


      Feb 21, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  regression-prod-7.39.0

  Regression bug that was found in production in release 7.39.0
 label


      Feb 21, 2025

    

  



  

  

    
  


  

      

    @digiwand
digiwand



    mentioned this issue
    
      Feb 21, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    

    

      
    

    


      

          @digiwand
digiwand




            added
      

  team-confirmations

  Push issues to confirmations team

    and removed
      

  regression-prod-7.39.0

  Regression bug that was found in production in release 7.39.0

  labels


      Feb 21, 2025

    

  



    

    

      
    

    


      

          @digiwand
digiwand




              self-assigned this


      Feb 21, 2025

    

  



  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Feb 24, 2025
    
    

      


  

    

      


  

      
        @digiwand
  





      

        
          fix: TypedSignDecoded revoke state changes should show "Revoke" not "…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          b50ca45
        
      

    

  

    

      
…Spending cap" (#13665)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This issue has been around since
#12994 upon launching
the decoding simulation

## **Related issues**

Fixes: #13664

## **Manual testing steps**

1. Create a decoded simulation revoke transaction 

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by severity


      Feb 24, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by team


      Feb 24, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-7.42.0

  Issue or pull request that will be included in release 7.42.0
 label


      Feb 24, 2025

    

  












  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @digiwand
  
    digiwand
    

      








      


  


  

    Labels
  



    

      

    release-7.42.0

  Issue or pull request that will be included in release 7.42.0
  

    team-confirmations

  Push issues to confirmations team
  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: Fixed

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          
  

    

      
    

  


      

    

  
      

  

    

      2 participants
    

    

        
          @digiwand 
        
          @metamaskbot