fix: TypedSignDecoded revoke

MetaMask · Feb 21, 2025 · f60242e · f60242e
1 parent a9cd3af
commit f60242e
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/...mponents/Confirm/Info/TypedSignV3V4/Simulation/TypedSignDecoded/TypedSignDecoded.test.tsx b/...mponents/Confirm/Info/TypedSignV3V4/Simulation/TypedSignDecoded/TypedSignDecoded.test.tsx
@@ -26,6 +26,16 @@ const stateChangesApprove = [
   },
 ];
 
+const stateChangesRevoke = [
+  {
+    assetType: 'ERC20',
+    changeType: DecodingDataChangeType.Revoke,
+    address: '0x3fc91a3afd70395cd496c647d5a6cc9d4b2b7fad',
+    amount: '12345',
+    contractAddress: '0x6b175474e89094c44da98b954eedeac495271d0f',
+  },
+];
+
 const stateChangesListingERC1155: DecodingDataStateChanges = [
   {
     assetType: 'NATIVE',
@@ -112,6 +122,17 @@ describe('DecodedSimulation', () => {
     await waitFor(() => expect(getByText('12,345')).toBeDefined());
   });
 
+  it('renders for ERC20 revoke', async () => {
+    const { getByText } = renderWithProvider(<TypedSignDecoded />, {
+      state: mockState(stateChangesRevoke),
+    });
+
+    expect(await getByText('Estimated changes')).toBeDefined();
+    expect(await getByText('Revoke')).toBeDefined();
+
+    await waitFor(() => expect(getByText('12,345')).toBeDefined());
+  });
+
   it('renders "Unlimited" for large values', async () => {
     const { getByText } = renderWithProvider(<TypedSignDecoded />, {
       state: mockState([{

diff --git a/...ns/components/Confirm/Info/TypedSignV3V4/Simulation/TypedSignDecoded/TypedSignDecoded.tsx b/...ns/components/Confirm/Info/TypedSignV3V4/Simulation/TypedSignDecoded/TypedSignDecoded.tsx
@@ -84,7 +84,7 @@ const getStateChangeLabelMap = (
         ? strings('confirm.simulation.label_change_type_nft_listing')
         : strings('confirm.simulation.label_change_type_receive'),
     [DecodingDataChangeType.Approve]: strings('confirm.simulation.label_change_type_permit'),
-    [DecodingDataChangeType.Revoke]: strings('confirm.simulation.label_change_type_permit'),
+    [DecodingDataChangeType.Revoke]: strings('confirm.simulation.label_change_type_revoke'),
     [DecodingDataChangeType.Bidding]: strings('confirm.simulation.label_change_type_bidding'),
     [DecodingDataChangeType.Listing]: strings('confirm.simulation.label_change_type_listing'),
   }[changeType]);