Skip to content

Commit

Permalink
cp-7.41.0 (#13590)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

fixes: #12857 

## **Description**

This PR corrects a linting issue and accidental typo in two files which
could cause our banner to render full width instead of with the intended
marginHorizontal.

We can see that both files where this typo exists has corresponding
references to this style which will be affected (by not being applied).
The codebase has been searched for all instances and these two were
flagged. It's obvious by looking at the two changes that they need to be
camelCase

## **Related issues**

Fixes:

## **Manual testing steps**

1. Trigger STX migration and use ApproveTransactionReview by using the
testdapp in mobile to deploy a smart contract.
2. Ensure that the Smart TransactionMigrationBanner displays with proper
margin and does not take up full width in this view. See screenshots
where BEFORE is the existing state with the typo causing the banner to
not display properly in the TransactionReview and the
ApproveTransactionReview, views and the AFTER is with the fix to use
camelCase as intended.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<img width="300" alt="STXBannerFullWidth"
src="https://github.com/user-attachments/assets/fcdcd746-3a6c-45d3-9b99-426a2650c43f"
/>

### **After**

<img width="300" alt="STXBannerMargin"
src="https://github.com/user-attachments/assets/47ddc977-b517-4cd4-84e0-c3a9ef4ef8b4"
/>

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
httpJunkie authored Feb 20, 2025
1 parent 4a5023e commit 8886b52
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ const createStyles = (colors: any) =>
marginTop: 20,
marginHorizontal: 10,
},
SmartTransactionsMigrationBanner: {
smartTransactionsMigrationBanner: {
marginHorizontal: 16,
},
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ class TransactionReview extends PureComponent {
/>
</View>
{shouldUseSmartTransaction && (
<View style={styles.SmartTransactionsMigrationBanner}>
<View style={styles.smartTransactionsMigrationBanner}>
<SmartTransactionsMigrationBanner />
</View>
)}
Expand Down

0 comments on commit 8886b52

Please sign in to comment.