Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - Removes t from props via metamask-connect; put t on context #3788

Merged
merged 5 commits into from
Mar 29, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Fix bug where the "Reset account" feature would not clear the network cache.
- Increase maximum gas limit, to allow very gas heavy transactions, since block gas limits have been stable.
- Allow user to select language on settings page

## 4.4.0 Mon Mar 26 2018

Expand Down
22 changes: 14 additions & 8 deletions ui/app/accounts/import/index.js
Original file line number Diff line number Diff line change
@@ -1,25 +1,31 @@
const inherits = require('util').inherits
const Component = require('react').Component
const h = require('react-hyperscript')
const connect = require('../../metamask-connect')
const PropTypes = require('prop-types')
const connect = require('react-redux').connect
import Select from 'react-select'

// Subviews
const JsonImportView = require('./json.js')
const PrivateKeyImportView = require('./private-key.js')


AccountImportSubview.contextTypes = {
t: PropTypes.func,
}

module.exports = connect()(AccountImportSubview)


inherits(AccountImportSubview, Component)
function AccountImportSubview () {
Component.call(this)
}

AccountImportSubview.prototype.getMenuItemTexts = function () {
return [
this.props.t('privateKey'),
this.props.t('jsonFile'),
this.context.t('privateKey'),
this.context.t('jsonFile'),
]
}

Expand All @@ -32,7 +38,7 @@ AccountImportSubview.prototype.render = function () {
h('div.new-account-import-form', [

h('.new-account-import-disclaimer', [
h('span', this.props.t('importAccountMsg')),
h('span', this.context.t('importAccountMsg')),
h('span', {
style: {
cursor: 'pointer',
Expand All @@ -43,12 +49,12 @@ AccountImportSubview.prototype.render = function () {
url: 'https://metamask.helpscoutdocs.com/article/17-what-are-loose-accounts',
})
},
}, this.props.t('here')),
}, this.context.t('here')),
]),

h('div.new-account-import-form__select-section', [

h('div.new-account-import-form__select-label', this.props.t('selectType')),
h('div.new-account-import-form__select-label', this.context.t('selectType')),

h(Select, {
className: 'new-account-import-form__select',
Expand Down Expand Up @@ -80,9 +86,9 @@ AccountImportSubview.prototype.renderImportView = function () {
const current = type || menuItems[0]

switch (current) {
case this.props.t('privateKey'):
case this.context.t('privateKey'):
return h(PrivateKeyImportView)
case this.props.t('jsonFile'):
case this.context.t('jsonFile'):
return h(JsonImportView)
default:
return h(JsonImportView)
Expand Down
25 changes: 15 additions & 10 deletions ui/app/accounts/import/json.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const Component = require('react').Component
const PropTypes = require('prop-types')
const h = require('react-hyperscript')
const connect = require('../../metamask-connect')
const connect = require('react-redux').connect
const actions = require('../../actions')
const FileInput = require('react-simple-file-input').default

Expand All @@ -24,11 +24,11 @@ class JsonImportSubview extends Component {
return (
h('div.new-account-import-form__json', [

h('p', this.props.t('usedByClients')),
h('p', this.context.t('usedByClients')),
h('a.warning', {
href: HELP_LINK,
target: '_blank',
}, this.props.t('fileImportFail')),
}, this.context.t('fileImportFail')),

h(FileInput, {
readAs: 'text',
Expand All @@ -43,7 +43,7 @@ class JsonImportSubview extends Component {

h('input.new-account-import-form__input-password', {
type: 'password',
placeholder: this.props.t('enterPassword'),
placeholder: this.context.t('enterPassword'),
id: 'json-password-box',
onKeyPress: this.createKeyringOnEnter.bind(this),
}),
Expand All @@ -53,13 +53,13 @@ class JsonImportSubview extends Component {
h('button.btn-secondary.new-account-create-form__button', {
onClick: () => this.props.goHome(),
}, [
this.props.t('cancel'),
this.context.t('cancel'),
]),

h('button.btn-primary.new-account-create-form__button', {
onClick: () => this.createNewKeychain(),
}, [
this.props.t('import'),
this.context.t('import'),
]),

]),
Expand All @@ -84,22 +84,22 @@ class JsonImportSubview extends Component {
const state = this.state

if (!state) {
const message = this.props.t('validFileImport')
const message = this.context.t('validFileImport')
return this.props.displayWarning(message)
}

const { fileContents } = state

if (!fileContents) {
const message = this.props.t('needImportFile')
const message = this.context.t('needImportFile')
return this.props.displayWarning(message)
}

const passwordInput = document.getElementById('json-password-box')
const password = passwordInput.value

if (!password) {
const message = this.props.t('needImportPassword')
const message = this.context.t('needImportPassword')
return this.props.displayWarning(message)
}

Expand All @@ -112,7 +112,7 @@ JsonImportSubview.propTypes = {
goHome: PropTypes.func,
displayWarning: PropTypes.func,
importNewJsonAccount: PropTypes.func,
t: PropTypes.func,
t: PropTypes.func,
}

const mapStateToProps = state => {
Expand All @@ -129,4 +129,9 @@ const mapDispatchToProps = dispatch => {
}
}

JsonImportSubview.contextTypes = {
t: PropTypes.func,
}

module.exports = connect(mapStateToProps, mapDispatchToProps)(JsonImportSubview)

14 changes: 10 additions & 4 deletions ui/app/accounts/import/private-key.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
const inherits = require('util').inherits
const Component = require('react').Component
const h = require('react-hyperscript')
const connect = require('../../metamask-connect')
const PropTypes = require('prop-types')
const connect = require('react-redux').connect
const actions = require('../../actions')

PrivateKeyImportView.contextTypes = {
t: PropTypes.func,
}

module.exports = connect(mapStateToProps, mapDispatchToProps)(PrivateKeyImportView)


function mapStateToProps (state) {
return {
error: state.appState.warning,
Expand Down Expand Up @@ -33,7 +39,7 @@ PrivateKeyImportView.prototype.render = function () {
return (
h('div.new-account-import-form__private-key', [

h('span.new-account-create-form__instruction', this.props.t('pastePrivateKey')),
h('span.new-account-create-form__instruction', this.context.t('pastePrivateKey')),

h('div.new-account-import-form__private-key-password-container', [

Expand All @@ -50,13 +56,13 @@ PrivateKeyImportView.prototype.render = function () {
h('button.btn-secondary--lg.new-account-create-form__button', {
onClick: () => goHome(),
}, [
this.props.t('cancel'),
this.context.t('cancel'),
]),

h('button.btn-primary--lg.new-account-create-form__button', {
onClick: () => this.createNewKeychain(),
}, [
this.props.t('import'),
this.context.t('import'),
]),

]),
Expand Down
12 changes: 9 additions & 3 deletions ui/app/accounts/import/seed.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
const inherits = require('util').inherits
const Component = require('react').Component
const h = require('react-hyperscript')
const connect = require('../../metamask-connect')
const PropTypes = require('prop-types')
const connect = require('react-redux').connect

SeedImportSubview.contextTypes = {
t: PropTypes.func,
}

module.exports = connect(mapStateToProps)(SeedImportSubview)


function mapStateToProps (state) {
return {}
}
Expand All @@ -20,10 +26,10 @@ SeedImportSubview.prototype.render = function () {
style: {
},
}, [
this.props.t('pasteSeed'),
this.context.t('pasteSeed'),
h('textarea'),
h('br'),
h('button', this.props.t('submit')),
h('button', this.context.t('submit')),
])
)
}
17 changes: 11 additions & 6 deletions ui/app/accounts/new-account/create-form.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
const { Component } = require('react')
const PropTypes = require('prop-types')
const h = require('react-hyperscript')
const connect = require('../../metamask-connect')
const connect = require('react-redux').connect
const actions = require('../../actions')

class NewAccountCreateForm extends Component {
constructor (props) {
constructor (props, context) {
super(props)

const { numberOfExistingAccounts = 0 } = props
const newAccountNumber = numberOfExistingAccounts + 1

this.state = {
newAccountName: '',
defaultAccountName: this.props.t('newAccountNumberName', [newAccountNumber]),
defaultAccountName: context.t('newAccountNumberName', [newAccountNumber]),
}
}

Expand All @@ -24,7 +24,7 @@ class NewAccountCreateForm extends Component {
return h('div.new-account-create-form', [

h('div.new-account-create-form__input-label', {}, [
this.props.t('accountName'),
this.context.t('accountName'),
]),

h('div.new-account-create-form__input-wrapper', {}, [
Expand All @@ -40,13 +40,13 @@ class NewAccountCreateForm extends Component {
h('button.btn-secondary--lg.new-account-create-form__button', {
onClick: () => this.props.goHome(),
}, [
this.props.t('cancel'),
this.context.t('cancel'),
]),

h('button.btn-primary--lg.new-account-create-form__button', {
onClick: () => this.props.createAccount(newAccountName || defaultAccountName),
}, [
this.props.t('create'),
this.context.t('create'),
]),

]),
Expand Down Expand Up @@ -97,4 +97,9 @@ const mapDispatchToProps = dispatch => {
}
}

NewAccountCreateForm.contextTypes = {
t: PropTypes.func,
}

module.exports = connect(mapStateToProps, mapDispatchToProps)(NewAccountCreateForm)

14 changes: 10 additions & 4 deletions ui/app/accounts/new-account/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
const Component = require('react').Component
const h = require('react-hyperscript')
const PropTypes = require('prop-types')
const inherits = require('util').inherits
const connect = require('../../metamask-connect')
const connect = require('react-redux').connect
const actions = require('../../actions')
const { getCurrentViewContext } = require('../../selectors')
const classnames = require('classnames')
Expand Down Expand Up @@ -36,16 +37,21 @@ function AccountDetailsModal (props) {
}
}

AccountDetailsModal.contextTypes = {
t: PropTypes.func,
}

module.exports = connect(mapStateToProps, mapDispatchToProps)(AccountDetailsModal)


AccountDetailsModal.prototype.render = function () {
const { displayedForm, displayForm } = this.props

return h('div.new-account', {}, [

h('div.new-account__header', [

h('div.new-account__title', this.props.t('newAccount')),
h('div.new-account__title', this.context.t('newAccount')),

h('div.new-account__tabs', [

Expand All @@ -55,15 +61,15 @@ AccountDetailsModal.prototype.render = function () {
'new-account__tabs__unselected cursor-pointer': displayedForm !== 'CREATE',
}),
onClick: () => displayForm('CREATE'),
}, this.props.t('createDen')),
}, this.context.t('createDen')),

h('div.new-account__tabs__tab', {
className: classnames('new-account__tabs__tab', {
'new-account__tabs__selected': displayedForm === 'IMPORT',
'new-account__tabs__unselected cursor-pointer': displayedForm !== 'IMPORT',
}),
onClick: () => displayForm('IMPORT'),
}, this.props.t('import')),
}, this.context.t('import')),

]),

Expand Down
Loading