fix: account syncing was not working after upgrading from a previous version

[mathieuartu]

Description

Account syncing was depending on _addAccountsWithBalance to be finished before being triggered.
But _addAccountsWithBalance was only triggered after onboarding.

So people upgrading from a previous version of the extension were not able to use account syncing since _addAccountsWithBalance was triggered during their original onboarding, at a time where account syncing was not available.

Additionally, the state value isAccountSyncingReadyToBeDispatched from UserStorageController was not persisted. So people were not able to use account syncing after upgrading their extension version, even coming from a version that had account syncing enabled and working.

This PR fixes that, by adding a migration that sets isAccountSyncingReadyToBeDispatched to true if completedOnboarding is true.

Also, bumping @metamask/profile-sync-controller to version v4.1.0 will ensure that isAccountSyncingReadyToBeDispatched is persisted. (MetaMask/core#5147)

Related issues

Fixes: #29679

Manual testing steps

1. Install MetaMask v12.9.3
2. Complete onboarding
3. Upgrade to this PR version
4. Verify that account syncing is working

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/profile-sync-controller@4.1.0 🔁 npm/@metamask/profile-sync-controller@4.0.1	None	0	1.49 MB	metamaskbot

View full report↗︎

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[metamaskbot]

Builds ready [ec946ad]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1766 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	407	1998	1599	413	198
		domContentLoaded	1514	2143	1737	183	88
		load	1539	2150	1766	181	87
		domInteractive	27	95	47	22	10
		backgroundConnect	10	139	34	30	14
		firstReactRender	17	98	66	29	14
		getState	5	67	18	21	10
		initialActions	0	1	0	0	0
		loadScripts	1117	1573	1299	146	70
		setupStore	6	74	11	14	7
		uiStartup	1717	2579	2165	259	124

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.39 KiB (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [4728285]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1855 ± 130 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	469	2704	1782	405	195
		domContentLoaded	1482	2617	1826	266	128
		load	1506	2707	1855	271	130
		domInteractive	27	201	58	45	22
		backgroundConnect	5	86	27	22	11
		firstReactRender	18	104	49	27	13
		getState	6	93	18	23	11
		initialActions	0	1	0	0	0
		loadScripts	1047	1974	1383	226	109
		setupStore	6	66	16	18	9
		uiStartup	1785	3298	2123	333	160

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 1.39 KiB (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)