Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fully remove eth_sign #24756

Merged
merged 42 commits into from
Aug 1, 2024
Merged
Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d144c05
fully remove eth_sign support
adonesky1 May 23, 2024
b827c9f
remove disabledRpcMethodPreferences, need migration
adonesky1 May 23, 2024
2e5e349
remove more instances of eth_sign
adonesky1 May 23, 2024
dfda3d8
fix up e2e tests
adonesky1 May 23, 2024
7004a8c
lint
adonesky1 May 24, 2024
bdb2f26
fix post rebase
adonesky1 Jun 25, 2024
24867a7
remove more instances
adonesky1 Jul 18, 2024
aad870b
bump @metamask/signature-controller and @metamask/logging-controller …
adonesky1 Jul 18, 2024
9db3cc7
Update LavaMoat policies
metamaskbot Jul 18, 2024
60271aa
fix mmi-controller
adonesky1 Jul 18, 2024
d44feda
more cleanup
adonesky1 Jul 18, 2024
8eab5f8
final fix
adonesky1 Jul 18, 2024
12b2ae2
update test
adonesky1 Jul 18, 2024
29ed8da
more cleanup
adonesky1 Jul 18, 2024
22d099c
further cleanup
adonesky1 Jul 19, 2024
6c131d4
lint + tests fix
adonesky1 Jul 19, 2024
aee10a2
yet more cleanup
adonesky1 Jul 19, 2024
07ecf4e
fix
adonesky1 Jul 19, 2024
8a6bca2
delete signature-request-original which is no longer used
adonesky1 Jul 19, 2024
2f2fa57
more cleanup
adonesky1 Jul 22, 2024
901f1a4
remove unused translation strings
adonesky1 Jul 23, 2024
a215579
Merge remote-tracking branch 'origin' into ad/remove-eth_sign
adonesky1 Jul 23, 2024
76be3ae
Update LavaMoat policies
metamaskbot Jul 23, 2024
cf45d99
fix unit tests
adonesky1 Jul 23, 2024
57cadc8
remove react-inspector?
adonesky1 Jul 23, 2024
ac70810
Revert "delete signature-request-original which is no longer used"
adonesky1 Jul 24, 2024
fefcabf
Revert "remove react-inspector?"
adonesky1 Jul 24, 2024
cf29842
revert
adonesky1 Jul 24, 2024
6800c70
Revert "remove unused translation strings"
adonesky1 Jul 24, 2024
c4282fc
fix issue with signature-request-original
adonesky1 Jul 24, 2024
4db3ff4
fixing unapprovedTypedMessages
adonesky1 Jul 24, 2024
a80af09
cleanup
adonesky1 Jul 24, 2024
ae4541c
Merge remote-tracking branch 'origin' into ad/remove-eth_sign
adonesky1 Jul 24, 2024
0f381ed
Update LavaMoat policies
metamaskbot Jul 24, 2024
1819b9e
Merge branch 'develop' into ad/remove-eth_sign
HowardBraham Jul 24, 2024
e24493a
Merge branch 'develop' into ad/remove-eth_sign
adonesky1 Jul 25, 2024
b5b9844
Merge remote-tracking branch 'origin' into ad/remove-eth_sign
adonesky1 Jul 26, 2024
4b9313f
update yarn.lock
adonesky1 Jul 29, 2024
2219e0d
address feedback
adonesky1 Jul 29, 2024
343ee96
address feedback + cleanup
adonesky1 Jul 30, 2024
e3f16cc
Merge branch 'develop' into ad/remove-eth_sign
adonesky1 Jul 30, 2024
7c1a3b8
remove more unused localization strings
adonesky1 Jul 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .storybook/initial-states/transactions.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ const MOCK_TX_TYPE = {
INCOMING: 'incoming',
PERSONAL_SIGN: 'personal_sign',
RETRY: 'retry',
SIGN: 'eth_sign',
SIGN_TYPED_DATA: 'eth_signTypedData',
SIMPLE_SEND: 'simpleSend',
SMART: 'smart',
Expand Down Expand Up @@ -420,27 +419,6 @@ export const MOCK_TRANSACTION_BY_TYPE = {
'Error: [ethjs-query] while formatting outputs from RPC \'{"value":{"code":-32000,"message":"replacement transaction underpriced"}}\'\n at chrome-extension://hbljfohiafgaaaabejngpgolnboohpaf/common-5.js:14346:29',
},
},
[MOCK_TX_TYPE.SIGN]: {
id: 5177046356058675,
msgParams: {
from: '0xabce7847fd3661a9b7c86aaf1daea08d9da5750e',
data:
'0x879a053d4800c6354e76c7985a865d2922c82fb5b3f4577b2fe08b998954f2e0',
origin: 'https://metamask.github.io',
},
txParams: {
from: '0xabc14609ef9e09776ac5fe00bdbfef57bcdefebb',
gas: '0x5208',
gasPrice: '0x77359400',
nonce: '0x3',
value: '0x00',
data:
'0x608060405234801561001057600080fd5b5033600160006101000a81548173ffffffffffffffffffffffffffffffffffffffff021916908373ffffffffffffffffffffffffffffffffffffffff1602179055506000808190555061023b806100686000396000f300608060405260043610610057576000357c0100000000000000000000000000000000000000000000000000000000900463ffffffff1680632e1a7d4d1461005c5780638da5cb5b1461009d578063d0e30db0146100f4575b600080fd5b34801561006857600080fd5b5061008760048036038101908080359060200190929190505050610112565b6040518082815260200191505060405180910390f35b3480156100a957600080fd5b506100b26101d0565b604051808273ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff16815260200191505060405180910390f35b6100fc6101f6565b6040518082815260200191505060405180910390f35b6000600160009054906101000a900473ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff163373ffffffffffffffffffffffffffffffffffffffff1614151561017057600080fd5b8160008082825403925050819055503373ffffffffffffffffffffffffffffffffffffffff166108fc839081150290604051600060405180830381858888f193505050501580156101c5573d6000803e3d6000fd5b506000549050919050565b600160009054906101000a900473ffffffffffffffffffffffffffffffffffffffff1681565b60003460008082825401925050819055506000549050905600a165627a7a72305820f237db3ec816a52589d82512117bc85bc08d3537683ffeff9059108caf3e5d400029',
},
time: 1653451051909,
status: 'unapproved',
type: 'eth_sign',
},
[MOCK_TX_TYPE.SIGN_TYPED_DATA]: {
id: 5177046356058598,
msgParams: {
Expand Down
2 changes: 0 additions & 2 deletions .storybook/test-data.js
Original file line number Diff line number Diff line change
Expand Up @@ -1204,8 +1204,6 @@ const state = {
v: '0x93',
},
],
unapprovedMsgs: {},
unapprovedMsgCount: 0,
unapprovedPersonalMsgs: {},
unapprovedPersonalMsgCount: 0,
unapprovedDecryptMsgs: {},
Expand Down
39 changes: 0 additions & 39 deletions app/_locales/de/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 0 additions & 39 deletions app/_locales/el/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 0 additions & 39 deletions app/_locales/en/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 0 additions & 39 deletions app/_locales/es/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 0 additions & 39 deletions app/_locales/fr/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 0 additions & 39 deletions app/_locales/hi/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 0 additions & 39 deletions app/_locales/id/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading