Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize E2E tests to cut CI time in half #16417

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 8, 2022

Explanation

Adds logic in run-all.js to allow for running E2E tests in parallel and enables parallelism in Circle CI.

Assuming the old configuration runs at around 60 minutes:

  • With parallelism: 4, the CI now runs a full 22 minutes faster than the old configuration.
  • With parallelism: 8, the CI now runs a full 28 minutes faster than the old configuration.

This means we can effectively cut CI time in half with this PR.

@metamaskbot
Copy link
Collaborator

Builds ready [3d36c50]
Page Load Metrics (2189 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint972171212713
domContentLoaded153926362163284136
load153926392189294141
domInteractive153826362163284136

@metamaskbot
Copy link
Collaborator

Builds ready [f04b358]
Page Load Metrics (2192 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint991831272110
domContentLoaded179027572167299144
load179027572192293141
domInteractive179027572167299144

@FrederikBolding FrederikBolding changed the title Experiment with parallellizing E2E Parallellize E2E tests to cut CI time in half Nov 8, 2022
@FrederikBolding FrederikBolding marked this pull request as ready for review November 8, 2022 12:30
@FrederikBolding FrederikBolding requested review from a team and kumavis as code owners November 8, 2022 12:30
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! Found one potential problem, otherwise looks good

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@FrederikBolding FrederikBolding changed the title Parallellize E2E tests to cut CI time in half Parallelize E2E tests to cut CI time in half Nov 8, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [a501534]
Page Load Metrics (2080 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint871019342
domContentLoaded15832277205018689
load15832340208018589
domInteractive15832277205018689

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking!

@FrederikBolding FrederikBolding merged commit 02088e4 into develop Nov 8, 2022
@FrederikBolding FrederikBolding deleted the fb/parallelize-e2e branch November 8, 2022 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants