-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelize E2E tests to cut CI time in half #16417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [3d36c50]
Page Load Metrics (2189 ± 141 ms)
|
Builds ready [f04b358]
Page Load Metrics (2192 ± 141 ms)
|
Gudahtt
reviewed
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Found one potential problem, otherwise looks good
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
approved these changes
Nov 8, 2022
Builds ready [a501534]
Page Load Metrics (2080 ± 89 ms)
|
mcmire
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Adds logic in
run-all.js
to allow for running E2E tests in parallel and enables parallelism in Circle CI.Assuming the old configuration runs at around 60 minutes:
parallelism: 4
, the CI now runs a full 22 minutes faster than the old configuration.parallelism: 8
, the CI now runs a full 28 minutes faster than the old configuration.This means we can effectively cut CI time in half with this PR.