fully remove eth_sign support

MetaMask · Jun 25, 2024 · 4ded566 · 4ded566
1 parent 7add8ac
commit 4ded566
Show file tree

Hide file tree

Showing 19 changed files with 2 additions and 481 deletions.
diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json
diff --git a/app/scripts/controllers/permissions/specifications.js b/app/scripts/controllers/permissions/specifications.js
@@ -370,7 +370,6 @@ export const unrestrictedMethods = Object.freeze([
   'eth_requestAccounts',
   'eth_sendRawTransaction',
   'eth_sendTransaction',
-  'eth_sign',
   'eth_signTypedData',
   'eth_signTypedData_v1',
   'eth_signTypedData_v3',

diff --git a/app/scripts/controllers/preferences.js b/app/scripts/controllers/preferences.js
@@ -47,9 +47,7 @@ export default class PreferencesController {
       useNonceField: false,
       usePhishDetect: true,
       dismissSeedBackUpReminder: false,
-      disabledRpcMethodPreferences: {
-        eth_sign: false,
-      },
+      disabledRpcMethodPreferences: {},
       useMultiAccountBalanceChecker: true,
       hasDismissedOpenSeaToBlockaidBanner: false,
       useSafeChainsListValidation: true,

diff --git a/app/scripts/lib/backup.test.js b/app/scripts/lib/backup.test.js
@@ -299,7 +299,6 @@ describe('Backup', function () {
         },
         methods: [
           'personal_sign',
-          'eth_sign',
           'eth_signTransaction',
           'eth_signTypedData_v1',
           'eth_signTypedData_v3',

diff --git a/app/scripts/lib/snap-keyring/metrics.test.ts b/app/scripts/lib/snap-keyring/metrics.test.ts
@@ -45,7 +45,6 @@ describe('getSnapAndHardwareInfoForMetrics', () => {
         options: {},
         methods: [
           'personal_sign',
-          'eth_sign',
           'eth_signTransaction',
           'eth_signTypedData_v1',
           'eth_signTypedData_v3',
@@ -97,7 +96,6 @@ describe('getSnapAndHardwareInfoForMetrics', () => {
         options: {},
         methods: [
           'personal_sign',
-          'eth_sign',
           'eth_signTransaction',
           'eth_signTypedData_v1',
           'eth_signTypedData_v3',

diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -1849,9 +1849,7 @@ export default class MetamaskController extends EventEmitter {
           `${this.loggingController.name}:add`,
         ],
       }),
-      isEthSignEnabled: () =>
-        this.preferencesController.store.getState()
-          ?.disabledRpcMethodPreferences?.eth_sign,
+      isEthSignEnabled: false,
       getAllState: this.getState.bind(this),
       getCurrentChainId: () =>
         this.networkController.state.providerConfig.chainId,

diff --git a/shared/constants/app.ts b/shared/constants/app.ts
@@ -36,7 +36,6 @@ export const MESSAGE_TYPE = {
   ETH_REQUEST_ACCOUNTS: 'eth_requestAccounts',
   ETH_SEND_TRANSACTION: 'eth_sendTransaction',
   ETH_SEND_RAW_TRANSACTION: 'eth_sendRawTransaction',
-  ETH_SIGN: 'eth_sign',
   ETH_SIGN_TRANSACTION: 'eth_signTransaction',
   ETH_SIGN_TYPED_DATA: 'eth_signTypedData',
   ETH_SIGN_TYPED_DATA_V1: 'eth_signTypedData_v1',

diff --git a/shared/constants/methods-tags.ts b/shared/constants/methods-tags.ts
@@ -26,7 +26,6 @@ export const methodsWithConfirmation = [
   'wallet_requestPermissions',
   'wallet_requestSnaps',
   'eth_decrypt',
-  'eth_sign',
   'eth_requestAccounts',
   'eth_getEncryptionPublicKey',
 ];
diff --git a/shared/constants/transaction.ts b/shared/constants/transaction.ts
@@ -11,7 +11,6 @@ export const IN_PROGRESS_TRANSACTION_STATUSES = [
 ];
 
 export const SIGNING_METHODS = Object.freeze([
-  'eth_sign',
   'eth_signTypedData',
   'eth_signTypedData_v1',
   'eth_signTypedData_v3',

diff --git a/ui/components/app/modals/eth-sign-modal/__snapshots__/eth-sign-modal.test.js.snap b/ui/components/app/modals/eth-sign-modal/__snapshots__/eth-sign-modal.test.js.snap