Swap out Buffer with browser-compatible Uint8Array #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
reviewed
Oct 18, 2022
Comment on lines
+254
to
+258
| public readonly chainCodeBuffer: Uint8Array; | ||
|
|
||
| public readonly privateKeyBuffer?: Buffer; | ||
| public readonly privateKeyBuffer?: Uint8Array; | ||
|
|
||
| public readonly publicKeyBuffer: Buffer; | ||
| public readonly publicKeyBuffer: Uint8Array; |
There was a problem hiding this comment.
This change will be breaking. Should we rename these properties to *Bytes instead of *Buffer instead?
There was a problem hiding this comment.
We're gonna do this in a follow-up.
rekmarks
reviewed
Oct 18, 2022
rekmarks
reviewed
Oct 18, 2022
rekmarks
requested changes
Oct 18, 2022
There was a problem hiding this comment.
In addition to my inline comment(s), there are some questions by @FrederikBolding that should be resolved before we merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bufferis a Node.js API and does not work in browsers without polyfills. This swaps out all usage ofBufferwithUint8Array, to make this library fully browser compatible without the need for polyfills.