-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bip39
implementation to @metamask/scure-bip39
#101
Conversation
bip-39
implementation to @metamask/scure-bip39
bip39
implementation to @metamask/scure-bip39
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The internals of this library will still expect the SRP to be passed as a string. We will need to make further changes to eliminate that assumption.
cc @Mrtenz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Could you elaborate on why this might be blocking that extension PR? I'm having trouble finding a connection. |
Not going to merge this yet @Gudahtt, @FrederikBolding has indicated that there may be some other adaptations required to make sure this is not breaking. I'm meeting with @Mrtenz tomorrow to discuss. |
I'm not sure if this is going to unblock that but it may be related. The error thrown here in the bip32 test-snap e2e test, is throw here in |
b4538a5
to
118d884
Compare
We are updating all instances of
bip39
across our packages to use the@metamask/scure-bip39
(our fork of@scure/bip39
) - which allows us to pass around SRP's asUint8Array
s rather than plain strings for security purposes.Currently this change may also be blocking: MetaMask/metamask-extension#17056