Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily use Node 22.5.1 to get CI to run #321

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Temporarily use Node 22.5.1 to get CI to run #321

merged 1 commit into from
Jul 19, 2024

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Jul 19, 2024

There seems to be a regression in Node 22.5.0 which prevents yarn install from running and in turns prevents CI from completing successfully. This regression was fixed in 22.5.1. We are using 22.x in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly.

@mcmire mcmire marked this pull request as ready for review July 19, 2024 19:51
@mcmire mcmire requested a review from a team as a code owner July 19, 2024 19:51
There seems to be a regression in Node 22.5.0 which [prevents `yarn
install` from running][1] and in turns prevents CI from completing
successfully. This regression was [fixed in 22.5.1][2]. We are using
`22.x` in CI, so in theory it should be using this version, but that
does not seem be the case right now. So this commit ensures that CI is
using this version by naming it explicitly.

[1]: yarnpkg/berry#6398
[2]: nodejs/node#53935
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit d701bf4 into main Jul 19, 2024
19 checks passed
@mcmire mcmire deleted the fix-ci branch July 19, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants