Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for eth_sign #320

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Remove support for eth_sign #320

merged 2 commits into from
Jul 26, 2024

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Jul 18, 2024 •
edited
Loading

Explanation

Months ago, because of phishing risk, we disabled the eth_sign API method by default (users could manually enable it with a preference toggle). Now because of additional risk associated with potentially malicious EIP-3074 invokers we are fully removing support for this method.

References

Related: https://github.com/MetaMask/MetaMask-planning/issues/2371

Extension PR: MetaMask/metamask-extension#24756

Changelog

Removed

  • BREAKING: Middleware for eth_sign method is removed
  • createWalletMiddleware no longer accepts processEthSignMessage as an option

@adonesky1 adonesky1 requested a review from a team as a code owner July 18, 2024 21:38
@adonesky1 adonesky1 force-pushed the ad/remove-eth_sign branch from e5f9e06 to fbc2bdd Compare July 24, 2024 19:17
@adonesky1 adonesky1 requested review from shanejonas and jiexi July 24, 2024 19:48
mcmire
mcmire approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the delay in reviewing this. It might be nice to add a sub-bullet in the changelog entry which lists which option we are removing from createWalletMiddleware. Other than that, though, this looks good.

@adonesky1 adonesky1 merged commit c66e899 into main Jul 26, 2024
19 checks passed
@adonesky1 adonesky1 deleted the ad/remove-eth_sign branch July 26, 2024 21:59
Gudahtt added a commit that referenced this pull request Oct 2, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into sync-v14-main
568232d 
* origin/main:
  fix: change types signatures verifyingContract validation to allow 'cosmos' as address (#334)
  Update `main` with changes from v14.0.1 (#332)
  Request validation should not throw if verifyingContract is not defined in typed signature (#328)
  Add changelog entries for `#318` (#327)
  remove eth_sign (#320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@shanejonas shanejonas Awaiting requested review from shanejonas

@jiexi jiexi Awaiting requested review from jiexi

Assignees
No one assigned
Labels
None yet
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adonesky1 @mcmire