Add sendCredentials option to createFetchMiddleware #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okies for cross-origin calls. createFetchMiddleware doesn't support calling into am Eth JSON RPC Node that's protected by cookie-based authentication. The standard approach to solving this is to tell fetch to send cookies along with CORS requests. This change adds a sendCredentials option to createFetchMiddleware that, when set to true, indicates cookies to be send for CORS requests.
|
Hi @brotchie, sorry it's taken us so long to respond to you on this. Would you mind enabling edits to your branch from maintainers? I've made some changes to this repo that resulted in a merge conflict on this PR, but I've fixed that on my end, so I'm happy to push up those changes and merge this PR once you enable edits :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createFetchMiddleware doesn't support calling into an Eth JSON RPC Node that's protected by cookie-based
authentication. The standard approach to solving this is to tell fetch to send cookies along with CORS
requests. This change adds a sendCredentials option to createFetchMiddleware that, when set to true,
indicates cookies to be send for CORS requests.