fix: return promise definition

MetaMask · Jul 22, 2024 · 3243082 · 3243082
1 parent cc04717
commit 3243082
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/block-ref.test.ts b/src/block-ref.test.ts
@@ -106,7 +106,7 @@ describe('createBlockRefMiddleware', () => {
                         '0x100',
                       ),
                     },
-                    response: async () => Promise.resolve('something'),
+                    response: async () => 'something',
                   }),
                 ]);
 
@@ -157,7 +157,7 @@ describe('createBlockRefMiddleware', () => {
                         '0x100',
                       ),
                     },
-                    response: async () => Promise.resolve('something'),
+                    response: async () => 'something',
                   }),
                 ]);
 
@@ -199,7 +199,7 @@ describe('createBlockRefMiddleware', () => {
                         '0x100',
                       ),
                     },
-                    response: async () => Promise.resolve('something'),
+                    response: async () => 'something',
                   }),
                 ]);
 
@@ -247,7 +247,7 @@ describe('createBlockRefMiddleware', () => {
                         '0x100',
                       ),
                     },
-                    response: async () => Promise.resolve('something'),
+                    response: async () => 'something',
                   }),
                 ]);
 

diff --git a/src/retryOnEmpty.test.ts b/src/retryOnEmpty.test.ts
@@ -147,7 +147,7 @@ describe('createRetryOnEmptyMiddleware', () => {
                 stubRequestThatFailsThenFinallySucceeds({
                   request,
                   numberOfTimesToFail: 9,
-                  successfulResponse: async () => Promise.resolve('something'),
+                  successfulResponse: async () => 'something',
                 }),
               ]);
 
@@ -252,7 +252,7 @@ describe('createRetryOnEmptyMiddleware', () => {
                 buildStubForBlockNumberRequest(blockNumber),
                 stubGenericRequest({
                   request,
-                  response: async () => Promise.resolve('success'),
+                  response: async () => 'success',
                 }),
               ]);
 

diff --git a/test/util/helpers.ts b/test/util/helpers.ts
@@ -139,7 +139,7 @@ export function buildStubForBlockNumberRequest(
       method: 'eth_blockNumber',
       params: [],
     },
-    response: async () => Promise.resolve(blockNumber),
+    response: async () => blockNumber,
   };
 }
 
@@ -221,7 +221,7 @@ export function stubProviderRequests(
         remainingStubs.splice(stubIndex, 1);
       }
 
-      return Promise.resolve(res);
+      return res;
     }
   });
 }