This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
fix _initFromMnemonic bug + get test coverage to 100% #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da2e2dc to
f98c952
Compare
Gudahtt
reviewed
Apr 18, 2022
| @@ -36,6 +43,17 @@ describe('hd-keyring', () => { | |||
| expect(accounts[1]).toStrictEqual(secondAcct); | |||
| }); | |||
|
|
|||
| it('constructs with a typeof array mnemonic', async () => { | |||
There was a problem hiding this comment.
There is a third type accepted: Buffer.
Gudahtt
reviewed
Apr 18, 2022
| keyring.generateRandomMnemonic(); | ||
| const output = await keyring.serialize(); | ||
| expect(output.numberOfAccounts).toBe(0); | ||
| expect(Array.isArray(output.mnemonic)).toBe(true); | ||
| }); | ||
|
|
||
| it('serializes mnemonic stored as a string in a class variable into a buffer array and does not add accounts', async () => { |
There was a problem hiding this comment.
Hmm. I suppose this test is useful because the mnemonic field isn't marked as private, but I really was thinking of it as private 🤔 Maybe we should have noted the type change of this field in the changelog as well.
There was a problem hiding this comment.
We can note the change when we push a patch release?
There was a problem hiding this comment.
Sure, we can amend the v4 changelog in that same PR.
Gudahtt
previously approved these changes
Apr 18, 2022
|
@Gudahtt added a test to cover the case you noted. |
Gudahtt
approved these changes
Apr 18, 2022
|
Thank you @adonesky1 for stepping in to fix the bugs that I must have missed in the original patch 😣 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where we are passing the unbuffered mnemonic to
bip39.mnemonicToSeedSyncwhen_initFromMnemonicis passed a typeof string mnemonicBump unit test coverage to 100%