This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
patch serialize and _initFromMnemonic to account for instances where mnemonic could be buffer array or string #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mnemonic could be buffer array or string
mcmire
suggested changes
Apr 4, 2022
Gudahtt
reviewed
Apr 4, 2022
54d6174 to
c4b81f8
Compare
mcmire
previously approved these changes
Apr 13, 2022
Gudahtt
reviewed
Apr 13, 2022
index.js
Outdated
| * BIP39-compliant mnemonic. | ||
| * | ||
| * @param {string|Array<number>|Buffer} mnemonic - A seed phrase represented | ||
| * as a string, an array of UTF-8 bytes, or a Buffer. |
There was a problem hiding this comment.
Maybe worth emphasizing here that the array and Buffer types are assumed to be NFKD-normalized: https://github.com/MetaMask/bip39/blob/master/ts_src/index.ts#L72-L73
There was a problem hiding this comment.
comment added here: 446ba4b
|
The |
c4b81f8 to
446ba4b
Compare
done here |
Gudahtt
reviewed
Apr 13, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds patch of this package currently implemented extension side to this repo.