Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 281.0.0 #5140

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Release 281.0.0 #5140

merged 8 commits into from
Jan 13, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jan 13, 2025

Major release for the accounts-controller. The InternalAccount and KeyringAccount now have a new scopes required field.

@ccharly ccharly requested review from a team as code owners January 13, 2025 20:59
@ccharly ccharly marked this pull request as draft January 13, 2025 20:59
@socket-security Socket Security
Copy link

socket-security bot commented Jan 13, 2025 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/accounts-controller@20.0.2, npm/@metamask/profile-sync-controller@3.3.0, npm/@metamask/transaction-controller@42.1.0

View full report↗︎

@ccharly ccharly marked this pull request as ready for review January 13, 2025 21:07
mcmire
mcmire previously requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entries look pretty good, thanks for adding those! Unfortunately I think we may need to include more packages in this release :(

packages/notification-services-controller/package.json Show resolved Hide resolved
packages/accounts-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/package.json Show resolved Hide resolved
packages/keyring-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/user-operation-controller/package.json
@@ -82,7 +82,7 @@
"@metamask/gas-fee-controller": "^22.0.0",
"@metamask/keyring-controller": "^19.0.0",
"@metamask/network-controller": "^22.0.0",
"@metamask/transaction-controller": "^42.0.0"
"@metamask/transaction-controller": "^43.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include this in the release as well, for reasons similar to previous?

mcmire
mcmire reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion and then we're good.

packages/profile-sync-controller/CHANGELOG.md Show resolved Hide resolved
@ccharly @mcmire
chore: update changelog
97a1b43 
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@mcmire mcmire dismissed their stale review January 13, 2025 22:44

Requested changes were made.

mcmire
mcmire approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccharly ccharly enabled auto-merge (squash) January 13, 2025 22:47
@ccharly ccharly merged commit adea818 into main Jan 13, 2025
117 checks passed
@ccharly ccharly deleted the release/281.0.0 branch January 13, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccharly @mcmire