Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove usage of deprecated setProviderType #3807

Merged
merged 1 commit into from
Jan 22, 2024
Merged

refactor: Remove usage of deprecated setProviderType #3807

merged 1 commit into from
Jan 22, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 22, 2024

Explanation

All uages of the deprecated NetworkController method setProviderType have been removed from this repository. They have been replaced by calls to setActiveNetwork, which now also supports being given network types, just like setProviderType did.

References

N/A

Changelog

@metamask/queued-request-controller

Changed

  • The action NetworkController:setProviderType is no longer used, so it's no longer required by the QueuedRequestController messenger.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Gudahtt Gudahtt marked this pull request as ready for review January 22, 2024 15:57
@Gudahtt Gudahtt requested a review from a team as a code owner January 22, 2024 15:57
mcmire
mcmire approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there'd be more places. Great!

@Gudahtt
refactor: Remove usage of deprecated setProviderType
4ef54df 
All uages of the deprecated `NetworkController` method
`setProviderType` have been removed from this repository. They have
been replaced by calls to `setActiveNetwork`, which now also supports
being given network types, just like `setProviderType` did.
@Gudahtt Gudahtt force-pushed the remove-usage-of-deprecated-set-provider-type-method branch from 1734f39 to 4ef54df Compare January 22, 2024 18:37
@Gudahtt Gudahtt merged commit ed8423e into main Jan 22, 2024
136 checks passed
@Gudahtt Gudahtt deleted the remove-usage-of-deprecated-set-provider-type-method branch January 22, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @mcmire