Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies for @metamask/accounts-controller #3747

Merged
merged 6 commits into from
Jan 22, 2024
Merged

chore: update dependencies for @metamask/accounts-controller #3747

merged 6 commits into from
Jan 22, 2024

Conversation

montelaidev
Copy link
Contributor

Explanation

This PR updates @metamask/eth-snap-keyring, @metamask/keyring-api, @metamask/snaps-sdk, @metamask/snaps-utils, and @metamask/snaps-controllers for the AccountsController.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@montelaidev montelaidev requested a review from a team as a code owner January 9, 2024 09:43
@socket-security Socket Security
Copy link

socket-security bot commented Jan 9, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-api@3.0.0 Transitive: environment, eval, filesystem, network, shell, unsafe +822 272 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/@metamask/snaps-controllers@4.1.0 shell Transitive: environment, eval, filesystem, network, unsafe +495 158 MB metamaskbot

View full report↗︎

@montelaidev montelaidev requested a review from danroc January 20, 2024 09:37
danroc
danroc reviewed Jan 22, 2024
View reviewed changes
packages/accounts-controller/src/AccountsController.test.ts Outdated
@@ -28,11 +28,20 @@ const mockGetKeyringForAccount = jest.fn();
const mockGetKeyringByType = jest.fn();
const mockGetAccounts = jest.fn();

const EOAEthMethods = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be EoaEthMethods for consistency

@montelaidev montelaidev force-pushed the bump/accounts-controller-deps-09012024 branch from b3e4c3e to eb98d7c Compare January 22, 2024 10:48
@socket-security Socket Security
Copy link

socket-security bot commented Jan 22, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/keyring-api@3.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@montelaidev montelaidev self-assigned this Jan 22, 2024
@montelaidev
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/keyring-api@3.0.0

@legobeat legobeat mentioned this pull request Jan 22, 2024
Closed
3 tasks
@gantunesr gantunesr changed the title Chore: Update dependencies for AccountsController chore: update dependencies for @metamask/accounts-controller Jan 22, 2024
legobeat
legobeat approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@legobeat legobeat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But seems yarn constraint enforce us to bump all in one go, so this more complete one LGTM.

Note that after this PR, @metamask/accounts-controller and @metamask/keyring-controller mix v2 and v3 of @metamask/keyring-api (as @metamask/eth-snap-keyring still pulls in v2)

So we're (temporarily I assume) trading consistency of the same dependency within one workspace for consistency of direct dependencies between worskpaces 🤷

@montelaidev montelaidev merged commit d5ad4bb into main Jan 22, 2024
136 checks passed
@montelaidev montelaidev deleted the bump/accounts-controller-deps-09012024 branch January 22, 2024 12:58
Gudahtt added a commit that referenced this pull request Jan 22, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into keep-preferences-cont…
abdaeea 
…roller-in-sync-with-keyrings

* origin/main:
  chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805)
  fix: custody keyring name (#3803)
  chore: update dependencies for `@metamask/accounts-controller` (#3747)
  fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802)
  feat: add methods to support ERC-4337 accounts (#3602)
  feat: add getAccount action to AccountsController (#1892)
Gudahtt added a commit that referenced this pull request Jan 22, 2024
@Gudahtt
Merge remote-tracking branch 'origin/main' into keep-preferences-cont…
ee153a6 
…roller-in-sync-with-keyrings

* origin/main:
  chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805)
  fix: custody keyring name (#3803)
  chore: update dependencies for `@metamask/accounts-controller` (#3747)
  fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802)
  feat: add methods to support ERC-4337 accounts (#3602)
  feat: add getAccount action to AccountsController (#1892)
@Gudahtt Gudahtt mentioned this pull request Jan 22, 2024
Merged
@Gudahtt Gudahtt mentioned this pull request Jan 23, 2024
Merged
3 tasks
montelaidev added a commit that referenced this pull request Jan 23, 2024
@montelaidev
Move keyring-controller dep to devdep in Accounts Controller (#3820)
de3dc1a 
## Explanation

Move the keyring-controller from a dependency to to dev dependency in
Accounts Controller. This was accidentally recategorized in #3747, this
PR undoes that change.

## References

## Changelog

### `@metamask/accounts-controller`

- **Changed**: Move keyring-controller from a dependency to
devDependency in the AccountsController

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@legobeat legobeat mentioned this pull request Mar 11, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danroc danroc danroc left review comments

@legobeat legobeat legobeat approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees

@montelaidev montelaidev

Labels
team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@montelaidev @gantunesr @danroc @legobeat @AlexJupiter