Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript to v4.2 #369

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Update TypeScript to v4.2 #369

merged 2 commits into from
Mar 16, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 25, 2021 •
edited
Loading

TypeScript has been updated to v4.2. I'm not aware of any changes that impact our code.

@typescript-eslint/eslint-plugin and typedoc were both updated to a version that supports TypeScript v4.2.

@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 25, 2021 •
edited
Loading

This depends upon #370

Note that technically @typescript-eslint/eslint-plugin doesn't support TypeScript v4.2 yet, as it hasn't updated its syntax parser to account for all new TypeScript v4.2 changes. It still works for us in practice because we aren't using the new syntax yet, but we might want to consider waiting until it is officially supported (progress is tracked here: typescript-eslint/typescript-eslint#2935)

TypeDoc also doesn't support this yet: TypeStrong/typedoc#1517

@Gudahtt Gudahtt changed the base branch from update-eslint-config to update-typescript-4.1 February 26, 2021 13:46
@Gudahtt Gudahtt force-pushed the update-typescript-4.1 branch from e8c4f91 to 042186c Compare February 26, 2021 14:55
Base automatically changed from update-typescript-4.1 to develop February 26, 2021 16:42
@Gudahtt Gudahtt removed the blocked label Mar 5, 2021
@Gudahtt
Copy link
Member Author

Gudahtt commented Mar 5, 2021

This should be unblocked now. Both @typescript-eslint/eslint-plugin and TypeDoc have released updates that include support for TypeScript v4.2.

@Gudahtt
Update TypeScript to v4.2
f402e1f 
TypeScript has been updated to v4.2 [1]. I'm not aware of any changes
that impact our code.

`@typescript-eslint/eslint-plugin` and `typedoc` were both updated to a
version that supports TypeScript v4.2.

[1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-2/
@Gudahtt Gudahtt force-pushed the update-typescript branch from c86e5bd to f402e1f Compare March 16, 2021 15:26
@Gudahtt Gudahtt marked this pull request as ready for review March 16, 2021 15:27
@Gudahtt Gudahtt requested a review from a team as a code owner March 16, 2021 15:27
@Gudahtt Gudahtt merged commit 1f87da3 into develop Mar 16, 2021
@Gudahtt Gudahtt deleted the update-typescript branch March 16, 2021 16:52
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Update TypeScript to v4.2 (#369)
c2fc971 
TypeScript has been updated to v4.2 [1]. I'm not aware of any changes
that impact our code.

`@typescript-eslint/eslint-plugin` and `typedoc` were both updated to a
version that supports TypeScript v4.2.

[1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-2/
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@Gudahtt @MajorLift
Update TypeScript to v4.2 (#369)
d8281f1 
TypeScript has been updated to v4.2 [1]. I'm not aware of any changes
that impact our code.

`@typescript-eslint/eslint-plugin` and `typedoc` were both updated to a
version that supports TypeScript v4.2.

[1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-2/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brad-decker brad-decker brad-decker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @brad-decker