Provide exported key with encryption #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b99fa8 to
981f03b
Compare
legobeat
reviewed
Oct 31, 2022
5f9a30d to
18ef8d7
Compare
18ef8d7 to
0300a86
Compare
Gudahtt
reviewed
Nov 2, 2022
|
@Gudahtt Should I rename |
|
That would make sense to me! Personally I think of this more as serialization/deserialization than import/export, but, import/export is fine and matches the crypto API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite to MetaMask/KeyringController#152
Provides the key in string format so it may be used to unlock.
Supercedes #20