Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Bump Node to v14 #146

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Bump Node to v14 #146

merged 5 commits into from
Aug 15, 2022

Conversation

bowensanders
Copy link
Contributor

This changes all refs to v12 to point to v14 as v12 is no longer LTS

@bowensanders bowensanders requested a review from a team as a code owner August 10, 2022 22:06
@paulmillr
Copy link

maybe also add v18

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. If we're interested in adding support for v18, maybe we do that in another PR in case there are any breakages we need to address.

@bowensanders
Copy link
Contributor Author

I agree on waiting until the next PR for 18 - i'm experimenting in the other bump to 14 pr's i'm working on with varied success, and I will be out for vacation for a couple weeks and don't want to logjam any projects over these bumps not going out on time if that's ok with everyone!

@bowensanders bowensanders merged commit b7b3e73 into main Aug 15, 2022
@bowensanders bowensanders deleted the bump-to-node-14 branch August 15, 2022 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants