Psyclone 3 support #388
Open
Psyclone 3 support #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 better compiler support
… only one artefact set is involved when running PSyclone.
…les to the default build artefact collections.
…eady in the output directory.
…ot replacing artefact).
…n in build (not source).
…ive compiler names are longer (crayftn-cray, craycc-cray).
… to avoid confusion with Craycc.
… new stle arguments and vice versa.
…ms with compiler wrapper which do not support this).
MatthewHambley
requested changes
Feb 17, 2025
Comment on lines
+70
to
+79
| # The behaviour of PSyclone changes from 2.5.0 to the next | ||
| # release. But since head-of-trunk still reports 2.5.0, we | ||
| # need to run additional tests to see if we have the official | ||
| # 2.5.0 release, or current trunk (which already has the new | ||
| # command line options). PSyclone needs an existing file | ||
| # in order to work, so use __file__ to present this file. | ||
| # PSyclone will obviously abort since this is not a Fortran | ||
| # file, but we only need to check the error message to | ||
| # see if the domain name is incorrect (--> current trunk) | ||
| # or not (2.5.0 release) |
There was a problem hiding this comment.
Not only has PSyclone 2.5.0 been released but so has 3.0.0. So any special cases can be removed and this section can be streamlined.
| self._api = api | ||
| self._version = None | ||
|
|
||
| def check_available(self) -> bool: |
There was a problem hiding this comment.
Can this whole complication, or a good section of it, be replaced by making use of shutil.which(...)?
Comment on lines
+127
to
+128
| if api and api.lower() == "nemo": | ||
| api = "" |
There was a problem hiding this comment.
Rather than trying to make on class support quite different versions of the tool would it make sense to have an old PSyclone and a new PSyclone class with some sort of factory process to choose between them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports the new 3.0 release, but also older PSyclone versions.