Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cellTopLabelAlignment to MessageSizeCalculator #1113

Conversation

marcetcheverry
Copy link

See #1106

@nathantannar4
Copy link
Member

Thanks for taking the time to make another PR @marcetcheverry 😁

When I looked at this issue I noticed that MessageContentCell.layoutCellTopLabel also needs updates for it to even use the assigned layout attributes.

Could that be added to this? Needs to look similar to layoutCellBottomLabel

Sent with GitHawk

@mdescalzo
Copy link
Contributor

mdescalzo commented Jun 27, 2019

@nathantannar4 I saw that in my poking around as well. I'm setting up a PR for it now: PR #1117

@nathantannar4
Copy link
Member

@mdescalzo I think this should all be done in one PR, as it's for the same issue. I appreciate you taking the time to do so none the less.

Sent with GitHawk

@nathantannar4 nathantannar4 changed the base branch from 3.0.0-swift5 to development July 8, 2019 01:35
@nathantannar4 nathantannar4 merged commit f54a8e7 into MessageKit:development Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants