Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Numbers to floats #106

Merged
merged 3 commits into from
Aug 14, 2023
Merged

fix: Numbers to floats #106

merged 3 commits into from
Aug 14, 2023

Conversation

pnadolny13
Copy link
Contributor

Closes #103

Warning: I think this is a breaking change because I believe the target will now try to update the type of existing columns from NUMBER to DOUBLE which throws a cannot change column NUM_COL from type NUMBER(38,0) to FLOAT.

@edgarrmondragon how do you think we should handle this in terms of breaking changes? Should this be the 1.0 release?

@edgarrmondragon
Copy link
Member

Since we're in the 0.* series still, I think doing a minor release for a breaking change is still acceptable and users may still feel some pain regardless if they bump to 0.5.0 or 1.0.0.

@pnadolny13
Copy link
Contributor Author

@edgarrmondragon do you have any thoughts or is this good to merge? I'll plan to cut a new minor release after this merges.

@edgarrmondragon
Copy link
Member

@pnadolny13 This LGTM. Let's just call out the potential breaking change in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: IndexError due to numeric precision logic
2 participants