Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

links are no longer rendered as links when passed to initial_comment #695

Closed
AllanOricil opened this issue Mar 28, 2023 · 6 comments
Closed
Assignees
Labels
Bug Something isn't working

Comments

@AllanOricil
Copy link

AllanOricil commented Mar 28, 2023

Description

V2
image

V3
image

initial_comment: "*Workflow:* <https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id}}|${{ github.workflow }}>\n*Commit:* <https://github.com/${{ github.repository }}/commit/${{ github.sha }}|${{ github.sha }}>"
@AllanOricil AllanOricil added the Bug Something isn't working label Mar 28, 2023
@AllanOricil
Copy link
Author

I don't know if it is a slack api issue or a problem with your action.

@AllanOricil
Copy link
Author

Old API render my links in Slack like this
image

The new API render them like this
image

@AllanOricil
Copy link
Author

This is probably a slack api bug
slackapi/node-slack-sdk#1599

@AllanOricil
Copy link
Author

It is a known limitation of v2
slackapi/node-slack-sdk#1561

@AllanOricil
Copy link
Author

You could add this information in the README

"Hey, because of slack v2 limitation, v3 might not work for you if your innitial_comment has links in it"

MeilCli added a commit that referenced this issue Apr 28, 2023
@MeilCli
Copy link
Owner

MeilCli commented Apr 28, 2023

Thanks your issue reporting.

I wrote its on README.

@MeilCli MeilCli closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants