Set Minimum Target Skill Level in Mass Training Dialog to 1 #5421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the JSpinner configuration to set the minimum skill level to 1 instead of 0. This prevents invalid values and ensures a consistent input range aligned with expected skill levels.
Previously, the skill level value could be clamped to 0, which is invalid. Updated the clamping logic to enforce a minimum value of 1, ensuring proper functionality and preventing potential errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5421 +/- ##
============================================
- Coverage 10.13% 10.11% -0.02%
+ Complexity 6081 6063 -18
============================================
Files 1052 1052
Lines 140315 140314 -1
Branches 20399 20399
============================================
- Hits 14224 14198 -26
- Misses 124739 124759 +20
- Partials 1352 1357 +5 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the JSpinner configuration to set the minimum skill level to 1 instead of 0. This prevents users accidentally locking themselves into an invalid state.
Fixes #5317 - I'm hoping this will retroactively fix any saves affected by this bug, too.