Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SVArmor Price Calculation #5289

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Dec 3, 2024

Adjusted the SVArmor price calculation to account for armor that doesn't exist at certain tech levels by returning zero cost. This change ensures we don't end up with a value of Infinity due to dividing by 0.0 -- the return value of ineligible (or non-existent) bar armor (specified elsewhere in the codebase).

Closes #5285

Adjusted the `SVArmor` price calculation to account for armor that doesn't exist at certain tech levels by returning zero cost. This change ensures we don't end up with a value of `Infinity` due to dividing by `0.0` -- the return value of ineligible (or non-existent) `bar` armor.
@IllianiCBT IllianiCBT added the Bug label Dec 3, 2024
@IllianiCBT IllianiCBT self-assigned this Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.47%. Comparing base (d333f62) to head (a381c59).
Report is 48 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5289   +/-   ##
=========================================
  Coverage     10.47%   10.47%           
  Complexity     6049     6049           
=========================================
  Files           959      959           
  Lines        135202   135205    +3     
  Branches      19674    19674           
=========================================
+ Hits          14165    14167    +2     
- Misses       119686   119689    +3     
+ Partials       1351     1349    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit e6d7143 into MegaMek:master Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants