Campaign now uses pickRandomCamouflage when initialized

[DM0000]

Modified pickRandomCamo to have "Root" faction that selects from all faction icons and implemented it in Campaign.

closes #5114

[DM0000]

Worked with all the start dates except the 3rd Jihad one but that one seems to be broken

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.47%. Comparing base (d333f62) to head (3f11631).
Report is 33 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5276      +/-   ##
============================================
- Coverage     10.47%   10.47%   -0.01%     
+ Complexity     6049     6048       -1     
============================================
  Files           959      959              
  Lines        135202   135203       +1     
  Branches      19674    19674              
============================================
- Hits          14165    14163       -2     
+ Misses       119686   119685       -1     
- Partials       1351     1355       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[IllianiCBT]

What error does that give you?

[DM0000]

Campaign file could not be loaded. Gives same error when I switch to master too.

[DM0000]

Also realize that maybe I should limit the camos to "Standard Camouflage" instead of all camos

[DM0000]

log error
16:11:30,946 ERROR [mekhq.gui.dialog.DataLoadingDialog] {AWT-EventQueue-0}
mekhq.gui.dialog.DataLoadingDialog$Task.done(DataLoadingDialog.java:436) -
java.util.concurrent.ExecutionException: java.lang.NumberFormatException: For input string: "7LA"

[IllianiCBT]

Perfect, we’re still tracking down the last of those from work that was done in 50.01. I’ll get that fixed in an hour

[DM0000]

Let me know if I should switch to just "Standard Camouflage" instead of all.

[IllianiCBT]

I think ‘all’ is perfectly fine. Gives a lot more choice and I don’t think anyone will mind if they get the same camo as a specific unit.

[IllianiCBT]

Thanks for taking a look at this.

LGTM :)